Skip to content

Make <menuitem> parse like an unknown element#2319

Merged
zcorpan merged 1 commit intomasterfrom
zcorpan/parse-menuitem-as-unknown
Feb 14, 2017
Merged

Make <menuitem> parse like an unknown element#2319
zcorpan merged 1 commit intomasterfrom
zcorpan/parse-menuitem-as-unknown

Conversation

@zcorpan
Copy link
Member

@zcorpan zcorpan commented Feb 3, 2017

Revert "Reconstruct active formatting elements for <menuitem>"

This reverts commit 2999aa0.

Revert "Fix #234: Change <menuitem> from void to like-<option>"

This reverts part of commit 5e49a20.

Not reverted:

  • List of void elements.
  • List of special elements.
  • Commented out no-op end tag handling.

Make <menuitem> parse like an unknown element

Fixes #2308.

@zcorpan zcorpan added topic: parser needs tests Moving the issue forward requires someone to write tests labels Feb 3, 2017
zcorpan added a commit to html5lib/html5lib-tests that referenced this pull request Feb 3, 2017
@zcorpan
Expect <menuitem> to parse like an unknown element
28f880e 
Follows whatwg/html#2319.
@zcorpan zcorpan mentioned this pull request Feb 3, 2017
Merged
@zcorpan zcorpan requested a review from hsivonen February 3, 2017 10:22
@zcorpan zcorpan removed the needs tests Moving the issue forward requires someone to write tests label Feb 3, 2017
@zcorpan zcorpan mentioned this pull request Feb 3, 2017
Closed
@zcorpan zcorpan added the do not merge yet Pull request must not be merged per rationale in comment label Feb 3, 2017
@zcorpan
Copy link
Member Author

zcorpan commented Feb 3, 2017

(Marking do not merge yet until #2308 (comment) is settled.)

@zcorpan zcorpan removed the do not merge yet Pull request must not be merged per rationale in comment label Feb 6, 2017
@domenic
Copy link
Member

domenic commented Feb 6, 2017

I think we can pull the trigger on this given 3/4.

@domenic domenic requested a review from RReverser February 6, 2017 21:28
@domenic
Copy link
Member

domenic commented Feb 6, 2017

@inikulin may also want to check this out, although apparently he's not part of the org so I can't assign him as a reviewer.

inikulin
inikulin approved these changes Feb 7, 2017
View reviewed changes
Copy link
Member

@inikulin inikulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@inikulin
Copy link
Member

inikulin commented Feb 7, 2017 •
edited
Loading

@domenic

although apparently he's not part of the org so I can't assign him as a reviewer.

That's odd, I'm listed as a member: https://github.com/orgs/whatwg/people?utf8=%E2%9C%93&query=inikulin

@annevk
Copy link
Member

annevk commented Feb 7, 2017

I added @inikulin to https://github.com/whatwg/html/settings/collaboration. Hopefully that makes it work better going forward.

@zcorpan
Make <menuitem> parse like an unknown element
4473bbe 
This partially reverts commits:
2999aa0
5e49a20

Fixes #2308.
@zcorpan zcorpan force-pushed the zcorpan/parse-menuitem-as-unknown branch from 8fb8485 to 4473bbe Compare February 10, 2017 07:42
@zcorpan
Copy link
Member Author

zcorpan commented Feb 10, 2017

Squashed and rebased to resolve conflicts with 916e1b9

iabudiab added a commit to iabudiab/HTMLKit that referenced this pull request Feb 11, 2017
@iabudiab
Expect <menuitem> to parse like an unknown element
05c6b9d 
This reverses the parser change introduced in commit:
b0bad50

The list of special elements is not reverted

The change was reverted in the spec:
whatwg/html#2319

and the html5lib-tests:
html5lib/html5lib-tests#88
hsivonen
hsivonen approved these changes Feb 14, 2017
View reviewed changes
Copy link
Member

@hsivonen hsivonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry about the delay.

@zcorpan zcorpan merged commit 0ca0377 into master Feb 14, 2017
@zcorpan zcorpan deleted the zcorpan/parse-menuitem-as-unknown branch February 14, 2017 17:31
nox added a commit to nox/html5ever that referenced this pull request Mar 16, 2017
@nox
Parse <menuitem> like an unknown element
e158dd9 
whatwg/html#2319
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Apr 17, 2017
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 17, 2017
Change <menuitem> parsing rules to match spec
921d518 
This CL changes <menuitem> parsing rules so that they match the current spec.
<menuitem> is no more a self closing tag.

The link below shows the latest change made to the spec.
whatwg/html#2319

BUG=412945

Review-Url: https://codereview.chromium.org/2819773002
Cr-Commit-Position: refs/heads/master@{#464906}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Apr 17, 2017
@chromium-wpt-export-bot
Change <menuitem> parsing rules to match spec
dfa7dfc 
This CL changes <menuitem> parsing rules so that they match the current spec.
<menuitem> is no more a self closing tag.

The link below shows the latest change made to the spec.
whatwg/html#2319

BUG=412945

Review-Url: https://codereview.chromium.org/2819773002
Cr-Commit-Position: refs/heads/master@{#464906}
scheib pushed a commit to scheib/chromium that referenced this pull request Apr 17, 2017
Change <menuitem> parsing rules to match spec
90d6ed6 
This CL changes <menuitem> parsing rules so that they match the current spec.
<menuitem> is no more a self closing tag.

The link below shows the latest change made to the spec.
whatwg/html#2319

BUG=412945

Review-Url: https://codereview.chromium.org/2819773002
Cr-Commit-Position: refs/heads/master@{#464906}
@domenic domenic mentioned this pull request Jun 28, 2017
Closed
craigbarnes added a commit to craigbarnes/lua-gumbo that referenced this pull request May 10, 2018
@craigbarnes
Remove special handling for <menuitem> tag
d5d0bb3 
It has been removed from the whatwg HTML spec and the html5lib
tests now expect it to be handled as an unknown element.

See also:

* https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem
* whatwg/html#2319
* html5lib/html5lib-tests#88

All html5lib tree-construction tests are now passing:

    Ran 1689 tests in 0.15s
    Passed: 1689
    Failed: 0
    Skipped: 0
stevecheckoway pushed a commit to stevecheckoway/nokogumbo that referenced this pull request Aug 19, 2018
@craigbarnes @stevecheckoway
Remove special handling for <menuitem> tag
2477e37 
It has been removed from the whatwg HTML spec and the html5lib
tests now expect it to be handled as an unknown element.

See also:

* https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem
* whatwg/html#2319
* html5lib/html5lib-tests#88

All html5lib tree-construction tests are now passing:

    Ran 1689 tests in 0.15s
    Passed: 1689
    Failed: 0
    Skipped: 0
stevecheckoway pushed a commit to rubys/nokogumbo that referenced this pull request Aug 22, 2018
@craigbarnes @stevecheckoway
Remove special handling for <menuitem> tag
4af5691 
It has been removed from the whatwg HTML spec and the html5lib
tests now expect it to be handled as an unknown element.

See also:

* https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem
* whatwg/html#2319
* html5lib/html5lib-tests#88

All html5lib tree-construction tests are now passing:

    Ran 1689 tests in 0.15s
    Passed: 1689
    Failed: 0
    Skipped: 0
chozekun pushed a commit to chozekun/gumbo-parser that referenced this pull request Dec 13, 2018
@craigbarnes @chozekun
Remove special handling for <menuitem> tag
de5fd61 
It has been removed from the whatwg HTML spec and the html5lib
tests now expect it to be handled as an unknown element.

See also:

* https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem
* whatwg/html#2319
* html5lib/html5lib-tests#88

All html5lib tree-construction tests are now passing:

    Ran 1689 tests in 0.15s
    Passed: 1689
    Failed: 0
    Skipped: 0
chozekun pushed a commit to chozekun/gumbo-parser that referenced this pull request Dec 16, 2018
@craigbarnes @chozekun
Remove special handling for <menuitem> tag
0b5d376 
It has been removed from the whatwg HTML spec and the html5lib
tests now expect it to be handled as an unknown element.

See also:

* https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem
* whatwg/html#2319
* html5lib/html5lib-tests#88

All html5lib tree-construction tests are now passing:

    Ran 1689 tests in 0.15s
    Passed: 1689
    Failed: 0
    Skipped: 0
chozekun pushed a commit to chozekun/gumbo-parser that referenced this pull request Dec 16, 2018
@craigbarnes @chozekun
Remove special handling for <menuitem> tag
653441b 
It has been removed from the whatwg HTML spec and the html5lib
tests now expect it to be handled as an unknown element.

See also:

* https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem
* whatwg/html#2319
* html5lib/html5lib-tests#88

All html5lib tree-construction tests are now passing:

    Ran 1689 tests in 0.15s
    Passed: 1689
    Failed: 0
    Skipped: 0
flavorjones pushed a commit to sparklemotion/nokogiri that referenced this pull request Apr 7, 2021
@craigbarnes @stevecheckoway
Remove special handling for <menuitem> tag
6402ba9 
It has been removed from the whatwg HTML spec and the html5lib
tests now expect it to be handled as an unknown element.

See also:

* https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menuitem
* whatwg/html#2319
* html5lib/html5lib-tests#88

All html5lib tree-construction tests are now passing:

    Ran 1689 tests in 0.15s
    Passed: 1689
    Failed: 0
    Skipped: 0
@mohd-akram mohd-akram mentioned this pull request May 18, 2023
Closed
wooorm pushed a commit to wooorm/html-void-elements that referenced this pull request May 19, 2023
@mohd-akram
Remove elements that are no longer void
7b5cb87 
Some obsolete elements got their void status takes away,
meaning `document.createElement(x).outerHTML` generates an opening and
closing tag, so this fix matches that behavior.

Related-to: whatwg/html#1095
Related-to: whatwg/html#2319

Closes GH-6.
Closes GH-7.
txgk added a commit to gumbo-parser/gumbo-parser that referenced this pull request Aug 26, 2025
@txgk
remove special handling for <menuitem> tag
d542836 
this lets us pass 13 more tests from html5lib-tests

whatwg/html#2319
html5lib/html5lib-tests#88
rubys/nokogumbo@4af5691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@inikulin inikulin inikulin approved these changes

@hsivonen hsivonen hsivonen approved these changes

@RReverser RReverser RReverser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hsivonen hsivonen

Labels

topic: parser

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zcorpan @domenic @inikulin @annevk @hsivonen @RReverser