Add keygen to the list of elements with special parsing rules#2224
Add keygen to the list of elements with special parsing rules#2224
Conversation
|
Per
it seems |
|
Hmm yeah OK. It'd be ideal if someone like @RReverser or @inikulin or @zcorpan who knows the parser stuff inside out could confirm for us, and then we could add a code comment if it's intentionally not there |
|
Relevant commits: I think this was an oversight. Special is cross-referenced (normatively) in: https://html.spec.whatwg.org/#parsing-main-inbody:special These do not apply to void elements since they can't be on the stack here. https://html.spec.whatwg.org/#parsing-main-inbody:special-3 Hmmmm. This ... algorithm has bugs, I think! Filed #2226. But this algorithm shouldn't have a difference if So all void elements should be in the special list, as far as I can tell. |
|
https://github.com/html5lib/html5lib-tests/search?utf8=✓&q=keygen - we could add some more tests for |
|
I've never added html5lib tests before---could someone help with that? Maybe @gsnedders? |
|
@domenic Is there anything much you need help with? Essentially, you have some input under #data, and some serialised expected tree under #document, and I think it's pretty obvious what that format is (there's a README that sorta defines it!). Pretty much ignore #errors for now. |
|
I guess contributing to html5lib is not that hard, but I'm really unsure which scenarios need more testing here. @zcorpan, would appreciate your help if possible. |
I remember this list being tricky in the past, but I can't see a reason why basefont would be included here and keygen wouldn't, so this is probably just a bug fix...