Skip to content

Conversation

@xxyzzzq
Copy link
Contributor

@xxyzzzq xxyzzzq commented Jun 9, 2016

Starting autoplay when media elements loaded is too agressive. Added
supplementary saying that the user agent may delay autoplay until video
elements become visible.

WICG/interventions#23

@xxyzzzq
Copy link
Contributor Author

xxyzzzq commented Jun 9, 2016

@foolip @mounirlamouri

@mounirlamouri
Copy link
Member

Content sgtm. The wording might be improved. Maybe something like: "then the user agent may also run the following substeps immediately or wait until [...]"?

@xxyzzzq
Copy link
Contributor Author

xxyzzzq commented Jun 9, 2016

Maybe something like: "then the user agent may also run the following substeps immediately or wait until [...]"?

Done.

@mounirlamouri
Copy link
Member

You might want to merge the two commits. lgtm otherwise. Thoug,h @foolip is the one who can merge :)

@xxyzzzq xxyzzzq force-pushed the autoplay_when_visible branch from 9a61f83 to 71adc34 Compare June 9, 2016 15:38
@xxyzzzq
Copy link
Contributor Author

xxyzzzq commented Jun 9, 2016

You might want to merge the two commits.

Done.

@xxyzzzq
Copy link
Contributor Author

xxyzzzq commented Jun 20, 2016

PTAL. Addressed our offline discussion with @foolip .

source Outdated
data-x="attr-media-autoplay">autoplay</code> attribute rather than using script to force the
video to play, so as to allow the user to override the behaviour if so desired.</p>

<p class="note">A <code>video</code> element is <dfn>visible in the user viewport</dfn> if and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove class="note" -- this paragraph defines a term and has requirements. :-)

@foolip
Copy link
Member

foolip commented Jun 21, 2016

This was trickier than expected with the event order, but I gave it a shot in 5cc7b99. @xxyzzzq, can you add that to your branch for easier reviewing? Can everyone including @xxyzzzq review the sum of changes to see if this makes sense? Discussion about event order in WICG/interventions#23.

@xxyzzzq xxyzzzq force-pushed the autoplay_when_visible branch from 3abd3a4 to 88e23f5 Compare June 22, 2016 09:51
Starting autoplay when media elements loaded is too agressive. Added
supplementary saying that the user agent may delay autoplay until video
elements become visible.
@xxyzzzq xxyzzzq force-pushed the autoplay_when_visible branch from 62ea2e7 to de799e3 Compare June 22, 2016 10:20
@xxyzzzq
Copy link
Contributor Author

xxyzzzq commented Jun 22, 2016

Merged the changes from @foolip , PTAL.

@zcorpan
Copy link
Member

zcorpan commented Jun 22, 2016

LGTM

foolip pushed a commit that referenced this pull request Jun 22, 2016
Starting autoplay when media elements loaded is too agressive. Added
supplementary saying that the user agent may delay autoplay until video
elements become visible.

PR: #1409
@foolip
Copy link
Member

foolip commented Jun 22, 2016

Pushed as 8ebd581, I had to add a reference back to this PR in the commit message but the source change is the same.

There is one thing that's still needed, and that's to look for event order tests in web-platform-tests and update them, or to write them if they don't exist. Any takers?

@foolip foolip closed this Jun 22, 2016
tharkum added a commit to tharkum/wpt that referenced this pull request Nov 13, 2025
Following the HTML specification, the order of events for
autoplaying media files (<video autoplay>) has been corrected:
- carplay, canplaythrough, play, playing

https://html.spec.whatwg.org/multipage/#ready-states:event-media-canplaythrough

WhatWG PR: whatwg/html#1409

Signed-off-by: Andrei Volykhin <andrei.volykhin@gmail.com>
tharkum added a commit to tharkum/wpt that referenced this pull request Nov 13, 2025
Following the HTML specification, the order of events for
autoplaying media files (<video autoplay>) has been corrected:
- carplay, canplaythrough, play, playing

https://html.spec.whatwg.org/multipage/#ready-states:event-media-canplaythrough

WhatWG PR: whatwg/html#1409

Signed-off-by: Andrei Volykhin <andrei.volykhin@gmail.com>
jdm pushed a commit to web-platform-tests/wpt that referenced this pull request Nov 14, 2025
Following the HTML specification, the order of events for
autoplaying media files (<video autoplay>) has been corrected:
- carplay, canplaythrough, play, playing

https://html.spec.whatwg.org/multipage/#ready-states:event-media-canplaythrough

WhatWG PR: whatwg/html#1409

Signed-off-by: Andrei Volykhin <andrei.volykhin@gmail.com>
lando-prod-mozilla bot pushed a commit to mozilla-firefox/firefox that referenced this pull request Nov 17, 2025
…lay media, a=testonly

Automatic update from web-platform-tests
media: Fix the order of events for autoplay media

Following the HTML specification, the order of events for
autoplaying media files (<video autoplay>) has been corrected:
- carplay, canplaythrough, play, playing

https://html.spec.whatwg.org/multipage/#ready-states:event-media-canplaythrough

WhatWG PR: whatwg/html#1409

Signed-off-by: Andrei Volykhin <andrei.volykhin@gmail.com>

--

wpt-commits: 5f6bfca0b535342b74a66485bbfeea563a857f8f
wpt-pr: 56014
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Nov 17, 2025
…lay media, a=testonly

Automatic update from web-platform-tests
media: Fix the order of events for autoplay media

Following the HTML specification, the order of events for
autoplaying media files (<video autoplay>) has been corrected:
- carplay, canplaythrough, play, playing

https://html.spec.whatwg.org/multipage/#ready-states:event-media-canplaythrough

WhatWG PR: whatwg/html#1409

Signed-off-by: Andrei Volykhin <andrei.volykhin@gmail.com>

--

wpt-commits: 5f6bfca0b535342b74a66485bbfeea563a857f8f
wpt-pr: 56014
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Nov 19, 2025
…lay media, a=testonly

Automatic update from web-platform-tests
media: Fix the order of events for autoplay media

Following the HTML specification, the order of events for
autoplaying media files (<video autoplay>) has been corrected:
- carplay, canplaythrough, play, playing

https://html.spec.whatwg.org/multipage/#ready-states:event-media-canplaythrough

WhatWG PR: whatwg/html#1409

Signed-off-by: Andrei Volykhin <andrei.volykhingmail.com>

--

wpt-commits: 5f6bfca0b535342b74a66485bbfeea563a857f8f
wpt-pr: 56014

UltraBlame original commit: 2fee79cba02206719799d576e15d26063ff99f4b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Nov 19, 2025
…lay media, a=testonly

Automatic update from web-platform-tests
media: Fix the order of events for autoplay media

Following the HTML specification, the order of events for
autoplaying media files (<video autoplay>) has been corrected:
- carplay, canplaythrough, play, playing

https://html.spec.whatwg.org/multipage/#ready-states:event-media-canplaythrough

WhatWG PR: whatwg/html#1409

Signed-off-by: Andrei Volykhin <andrei.volykhingmail.com>

--

wpt-commits: 5f6bfca0b535342b74a66485bbfeea563a857f8f
wpt-pr: 56014

UltraBlame original commit: 2fee79cba02206719799d576e15d26063ff99f4b
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Nov 19, 2025
…lay media, a=testonly

Automatic update from web-platform-tests
media: Fix the order of events for autoplay media

Following the HTML specification, the order of events for
autoplaying media files (<video autoplay>) has been corrected:
- carplay, canplaythrough, play, playing

https://html.spec.whatwg.org/multipage/#ready-states:event-media-canplaythrough

WhatWG PR: whatwg/html#1409

Signed-off-by: Andrei Volykhin <andrei.volykhingmail.com>

--

wpt-commits: 5f6bfca0b535342b74a66485bbfeea563a857f8f
wpt-pr: 56014

UltraBlame original commit: 2fee79cba02206719799d576e15d26063ff99f4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants