Skip light dismiss when opening select's picker#12008
Skip light dismiss when opening select's picker#12008josepharhar wants to merge 3 commits intowhatwg:mainfrom
Conversation
This PR prevents light dismiss from running immediately after clicking the select element's invoker button, which would close the base appearance picker as soon as the user releases the mouse since the picker is opened on mousedown.
|
I wonder if instead of this, would it be possible to do something like the following? in nearest inclusive target popover: If currentNode is a select that is being rendered as a drop-down box with base appearance, and select popover visibility state is showing, then return select popover. |
Thanks, that's much better! I put it in the popover target element algorithm instead and I'm implementing it in chromium here, which seems to work well. How does it look? |
|
looks good 👍 |
This patch prevents customizable select's popover from being light dismissed when the user clicks on the select to invoke the popover in a less hacky way. Spec PR: whatwg/html#12008 Change-Id: I1488ccdf3addf0df69ca252fcbb56da433bf3f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6912976 Reviewed-by: Joey Arhar <jarhar@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1560264}
|
@smaug---- @zcorpan @keithamus could I interested one of you to take a look at this? |
This PR prevents light dismiss from running immediately after clicking the select element's invoker button, which would close the base appearance picker as soon as the user releases the mouse since the picker is opened on mousedown.
(See WHATWG Working Mode: Changes for more details.)
/popover.html ( diff )