Define base appearance for list box select elements#11758
Define base appearance for list box select elements#11758zcorpan merged 3 commits intowhatwg:mainfrom
Conversation
|
I filed #11804 , I can review this again when that is fixed. I would suggest adding tests in this area that check which UA styles are applied, see e.g. https://github.com/web-platform-tests/wpt/blob/master/html/rendering/widgets/the-select-element/select-as-listbox-default-styles.tentative.html |
Thanks, I started a fix: #11805
Here is a test I'm working on: https://chromium-review.googlesource.com/c/chromium/src/+/6276680 |
|
Now that #11804 has been fixed and I have rebased this PR, and we got a resolution in the sizing issue, and we have a positive standards position from mozilla, this PR is ready for review. |
|
Some of the linked tests are tentative, is there a PR to make them not tentative? |
I added a chromium patch to make them non-tentative, which will generate a WPT PR later |
Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1561960}
Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1561960}
Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1561960}
…t-listbox tests, a=testonly Automatic update from web-platform-tests Remove tentative from customizable-select-listbox tests Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1561960} -- wpt-commits: b142a76f0ffffbc95b9053f30dacb2a4737e7f6a wpt-pr: 56900
…t-listbox tests, a=testonly Automatic update from web-platform-tests Remove tentative from customizable-select-listbox tests Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <masonfchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1561960} -- wpt-commits: b142a76f0ffffbc95b9053f30dacb2a4737e7f6a wpt-pr: 56900 UltraBlame original commit: 844b957c47941e80044e2d5c41b415f98cb7c920
…t-listbox tests, a=testonly Automatic update from web-platform-tests Remove tentative from customizable-select-listbox tests Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <masonfchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1561960} -- wpt-commits: b142a76f0ffffbc95b9053f30dacb2a4737e7f6a wpt-pr: 56900 UltraBlame original commit: 844b957c47941e80044e2d5c41b415f98cb7c920
…t-listbox tests, a=testonly Automatic update from web-platform-tests Remove tentative from customizable-select-listbox tests Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <masonfchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1561960} -- wpt-commits: b142a76f0ffffbc95b9053f30dacb2a4737e7f6a wpt-pr: 56900 UltraBlame original commit: 844b957c47941e80044e2d5c41b415f98cb7c920
Spec PR: whatwg/html#11758 Bug: 357649033 Change-Id: I259786e661f5eeb7f3cb6d1c29cce9c82f92795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7262091 Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1561960}
This PR defines base appearance for select elements which are being rendered as a list box, as opposed to the prior customizable select PR which defined base appearance for drop down select elements.
Fixes #11477
(See WHATWG Working Mode: Changes for more details.)
/form-elements.html ( diff )
/rendering.html ( diff )