Remove redundant recursive step of fullscreen element ready check#52
Merged
Conversation
Member
|
LGTM % update date before landing. |
HTML's "allowed to use" only returns true if the document is in the top-level browsing context, or if it's connected to it via any number of iframes, all of which must be in a document to have nested browsing contexts at all, so this final condition would always be true. Fixes #50.
50b8061 to
2f71e0b
Compare
Member
Author
|
Thanks for review, date changed in 9a75db6, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTML's "allowed to use" only returns true if the document is in the
top-level browsing context, or if it's connected to it via any number of
iframes, all of which must be in a document to have nested browsing
contexts at all, so this final condition would always be true.
Fixes #50.