Disallow dialog.requestFullscreen()#104
Merged
Merged
Conversation
This way, interactions between the algorithms for fullscreen and dialog are simplified. Example concern: #102 (comment) This also makes it easier to reinstate hierarchy restrictions: #91 Tests: https://chromium-review.googlesource.com/c/chromium/src/+/684435
upsuper
approved these changes
Sep 27, 2017
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 27, 2017
Follows whatwg/fullscreen#104 The compat risk is virtually none given how rarely this happens: https://www.chromestatus.com/metrics/feature/timeline/popularity/1998 https://www.chromestatus.com/metrics/feature/timeline/popularity/1999 Bug: 240576 Change-Id: Ifcd793251d50cd40fc2fc5ef5ee50343f0aac35f
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 28, 2017
Follows whatwg/fullscreen#104 The compat risk is virtually none given how rarely this happens: https://www.chromestatus.com/metrics/feature/timeline/popularity/1998 https://www.chromestatus.com/metrics/feature/timeline/popularity/1999 Bug: 240576 Change-Id: Ifcd793251d50cd40fc2fc5ef5ee50343f0aac35f Reviewed-on: https://chromium-review.googlesource.com/684435 Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#505007}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Sep 28, 2017
Follows whatwg/fullscreen#104 The compat risk is virtually none given how rarely this happens: https://www.chromestatus.com/metrics/feature/timeline/popularity/1998 https://www.chromestatus.com/metrics/feature/timeline/popularity/1999 Bug: 240576 Change-Id: Ifcd793251d50cd40fc2fc5ef5ee50343f0aac35f Reviewed-on: https://chromium-review.googlesource.com/684435 Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#505007}
MXEBot
pushed a commit
to mirror/chromium
that referenced
this pull request
Sep 29, 2017
Follows whatwg/fullscreen#104 The compat risk is virtually none given how rarely this happens: https://www.chromestatus.com/metrics/feature/timeline/popularity/1998 https://www.chromestatus.com/metrics/feature/timeline/popularity/1999 Bug: 240576 Change-Id: Ifcd793251d50cd40fc2fc5ef5ee50343f0aac35f Reviewed-on: https://chromium-review.googlesource.com/684435 Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#505007}
jakearchibald
pushed a commit
to jakearchibald/web-platform-tests
that referenced
this pull request
Nov 16, 2017
Follows whatwg/fullscreen#104 The compat risk is virtually none given how rarely this happens: https://www.chromestatus.com/metrics/feature/timeline/popularity/1998 https://www.chromestatus.com/metrics/feature/timeline/popularity/1999 Bug: 240576 Change-Id: Ifcd793251d50cd40fc2fc5ef5ee50343f0aac35f Reviewed-on: https://chromium-review.googlesource.com/684435 Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#505007}
nareix
pushed a commit
to nareix/webrtc.third_party
that referenced
this pull request
Mar 5, 2018
Follows whatwg/fullscreen#104 The compat risk is virtually none given how rarely this happens: https://www.chromestatus.com/metrics/feature/timeline/popularity/1998 https://www.chromestatus.com/metrics/feature/timeline/popularity/1999 Bug: 240576 Change-Id: Ifcd793251d50cd40fc2fc5ef5ee50343f0aac35f Reviewed-on: https://chromium-review.googlesource.com/684435 Reviewed-by: Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#505007} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 6bb356465c8ed15b692af8cc93e6b434cb69d5fd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way, interactions between the algorithms for fullscreen and
dialog are simplified. Example concern:
#102 (comment)
This also makes it easier to reinstate hierarchy restrictions:
#91
Tests: https://chromium-review.googlesource.com/c/chromium/src/+/684435
Preview | Diff