Merged
Conversation
The empty string is a better default as the field is optional in HTTP and rather meaningless. This way if you change the status and forget about statusText it won't give the mistaken impression things are OK. Tests: ... Fixes #698.
annevk
added a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 20, 2018
See whatwg/fetch#836 for context. This also cleans up the code a bit.
Member
Author
|
@youennf @yutakahirano what do you think? With browser bugs this is reasonable to do? It's an API change, but extremely minor. |
Member
|
FWIW I also think this makes sense, but do wonder how much potentially older JS out there is relying on "OK". |
Ms2ger
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 20, 2018
See whatwg/fetch#836 for context. This also cleans up the code a bit.
Member
Author
|
It seems unlikely given this only affects synthetic responses and you'd generally not check this field (or set it), but yes. |
Member
|
Oh that's right, good point. |
Member
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 26, 2018
…fault, a=testonly Automatic update from web-platform-testsFetch: change Response's statusText's default See whatwg/fetch#836 for context. This also cleans up the code a bit. -- wpt-commits: 99e9e996267ccd5c1344b7d0164c5e5763b3b174 wpt-pr: 14144
jankeromnes
pushed a commit
to jankeromnes/gecko
that referenced
this pull request
Nov 27, 2018
…fault, a=testonly Automatic update from web-platform-testsFetch: change Response's statusText's default See whatwg/fetch#836 for context. This also cleans up the code a bit. -- wpt-commits: 99e9e996267ccd5c1344b7d0164c5e5763b3b174 wpt-pr: 14144
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 30, 2018
From "OK" => "", as per the spec change whatwg/fetch#836. R=yhirano@chromium.org, yoav@yoav.ws Bug: 907441 Change-Id: Id58718ecdba49432078358c20d62df5ff0eda8f8 Reviewed-on: https://chromium-review.googlesource.com/c/1348739 Commit-Queue: Dominic Farolino <domfarolino@gmail.com> Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#612662}
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…fault, a=testonly Automatic update from web-platform-testsFetch: change Response's statusText's default See whatwg/fetch#836 for context. This also cleans up the code a bit. -- wpt-commits: 99e9e996267ccd5c1344b7d0164c5e5763b3b174 wpt-pr: 14144 UltraBlame original commit: 823f8312186515b6e7a6860306bb8d1f8e838cc8
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…fault, a=testonly Automatic update from web-platform-testsFetch: change Response's statusText's default See whatwg/fetch#836 for context. This also cleans up the code a bit. -- wpt-commits: 99e9e996267ccd5c1344b7d0164c5e5763b3b174 wpt-pr: 14144 UltraBlame original commit: 823f8312186515b6e7a6860306bb8d1f8e838cc8
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…fault, a=testonly Automatic update from web-platform-testsFetch: change Response's statusText's default See whatwg/fetch#836 for context. This also cleans up the code a bit. -- wpt-commits: 99e9e996267ccd5c1344b7d0164c5e5763b3b174 wpt-pr: 14144 UltraBlame original commit: 823f8312186515b6e7a6860306bb8d1f8e838cc8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The empty string is a better default as the field is optional in HTTP and rather meaningless. This way if you change the status and forget about statusText it won't give the mistaken impression things are OK.
Tests: ...
Fixes #698.
Preview | Diff