Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 14e6140 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Size Change: +185 B (0%) Total Size: 316 kB
ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## main #1006 +/- ##
==========================================
- Coverage 99.81% 97.43% -2.38%
==========================================
Files 264 260 -4
Lines 25802 25622 -180
Branches 2080 1830 -250
==========================================
- Hits 25754 24966 -788
- Misses 45 653 +608
Partials 3 3
|
tmm
approved these changes
Aug 9, 2023
src/utils/chain.ts
Outdated
Comment on lines
+33
to
+39
| config?: ChainConfig<formatters>, | ||
| ): Assign<chain, ChainConfig<formatters>> { | ||
| const { | ||
| fees = chain.fees, | ||
| formatters = chain.formatters, | ||
| serializers = chain.serializers, | ||
| } = config || {} |
Member
There was a problem hiding this comment.
nitpick
Suggested change
| config?: ChainConfig<formatters>, | |
| ): Assign<chain, ChainConfig<formatters>> { | |
| const { | |
| fees = chain.fees, | |
| formatters = chain.formatters, | |
| serializers = chain.serializers, | |
| } = config || {} | |
| config: ChainConfig<formatters> = {}, | |
| ): Assign<chain, ChainConfig<formatters>> { | |
| const { | |
| fees = chain.fees, | |
| formatters = chain.formatters, | |
| serializers = chain.serializers, | |
| } = config |
src/types/chain.ts
Outdated
Comment on lines
+32
to
+37
| getDefaultPriorityFee(args: { | ||
| block: Prettify<FormattedBlock<{ formatters: formatters }>> | ||
| request: PrepareRequestParameters< | ||
| Omit<Chain, 'formatters'> & { formatters: formatters } | ||
| > | ||
| }): Promise<bigint> | bigint |
Member
There was a problem hiding this comment.
Probably not worth adding another type here, but think it's worthwhile if this could also just be a bigint in addition to async/sync function that returns bigint? In that world, maybe it makes sense to rename the key from getDefaultPriorityFee to defaultPriorityFee.
import type { ChainFees } from '../../types/chain.js'
export const feesOptimism = {
defaultPriorityFee: 1_000_000n, // 0.001 gwei
} as const satisfies ChainFees
Merged
frolic
reviewed
Aug 10, 2023
| block, | ||
| request: request as PrepareRequestParameters, | ||
| }) | ||
| } |
aaronmgdr
pushed a commit
to celo-org/viem
that referenced
this pull request
Aug 18, 2023
* feat: optimism transaction receipt formatter * refactor: restructure * feat: chain fees config * chore: changeset * chore: update test * chore: impl * refactor: cleanup formatters & serializers types * chore: fix * refactor * chore: snapshots * Update sweet-lemons-explain.md * Update sweet-lemons-explain.md * refactor * refactor * refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
feestochainconfig that includes agetDefaultPriorityFeefor setting a default priority fee for a chain.Also cleaned up the chain serializers & formatters types. Probably makes more sense to have them in
types/chain.tsrather than separate files since they aren't related to anything else apart from the chain. Will also help if we scale to more than justfees,serializers&formatterson the chain config (and also when we chose to move the chains into a separate package).PR-Codex overview
Focus of this PR:
This PR focuses on adding a
feesfield to thechainconfiguration, which includes adefaultPriorityFeefor setting a default priority fee (maxFeePerGas) for a chain.Detailed summary:
feesfield tochainconfigfeesfield includes adefaultPriorityFeefor setting a default priority fee (maxFeePerGas) for a chainfeesfield in thechainconfiguration