Conversation
Using plain language to cut through all the technical complexity with the neural network model. Create initial gherkin placeholder `.feature` files and update README files highlighting this new development. Hopefully this helps to make it easier to understand for more people. Another benefit is that the core idea can be implemented in other ways (programming languages) when something better comes up!
Part of #51. Adding [Behave](https://github.com/behave/behave) as our behavioural driven development testing framework/library. Will use for running feature tests.
Slow down docker build time, while speeding up Continuous Integration tests. Reveal the codefresh pipeline used for running the unit tests. Also moved behave from regular packages to dev-packages in Pipfile.
One simple sample test to try out behave. Implement fixtures in features/environment.py file to load functions modules from ipynb files. Code borrowed from test_ipynb.ipynb, and using the Don't repeat yourself (DRY) principle, we extract the core _load_ipynb_modules from the original _doctest_ipynb function. Also have the integration tests added to test_ipynb.ipynb, and updated the markdown documentation inside the notebook.
Pytest doesn't like non-exactness of the time taken printed by behave's summary, so removing it. Also created an _integration_test_ipynb function that does the wrapping of the behave runner. Renamed _doctest_ipynb to _unit_test_ipynb to match this design change.
Various overdue fixes to sanitize the Continuous Integration builds and tests. Using pipenv install --deploy in Dockerfile to make sure Pipfile.lock is respected! Pipfile.lock is updated properly here after 6fff1e6. Also point codefresh badge to the right url (there was some confusion with multiple accounts).
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using plain language to cut through all the technical complexity with the neural network model. Hopefully this helps to make it easier to understand for more people. Another benefit is that the core idea can be implemented in other ways (programming languages) when something better comes up!
References:
TODO:
.featurefiles (02b0cea)