Don't quote commands on Windows anymore (#210)#213
Merged
Conversation
Member
Author
|
@raspopov Please have a look. |
Contributor
|
Looks good but I thought about something like that: Not sure what system requirement for WebSVN is. |
Member
Author
You are right, it still works with 7.x technically. I will modify. |
michael-o
added a commit
that referenced
this pull request
Jan 30, 2024
With PHP 8.0.0-RC2 the command handling has been simplified and improved. Quoting can be removed since it is now handled properly internally. See also php/php-src@9ca449e This fixes #210 and closes #213
Member
Author
|
Please check again. |
With PHP 8.0.0-RC2 the command handling has been simplified and improved. Quoting can be removed since it is now handled properly internally. See also php/php-src@9ca449e This fixes #210 and closes #213
Contributor
|
Good work! 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With PHP 8.0.0-RC2 the command handling has been simplified and improved. Quoting can be removed since it is now handled properly internally.
See also php/php-src@9ca449e
This fixes #210 and closes #213