Fix "Call to a member function isDownloadAllowed() on null" in dl.php#194
Merged
michael-o merged 1 commit intowebsvnphp:masterfrom Sep 30, 2023
Merged
Fix "Call to a member function isDownloadAllowed() on null" in dl.php#194michael-o merged 1 commit intowebsvnphp:masterfrom
michael-o merged 1 commit intowebsvnphp:masterfrom
Conversation
Fixes the following bug: Calling dl.php?repname=xxx where xxx is a non-existing repo causes the error "Call to a member function isDownloadAllowed() on null" . Note: I have now verified that all PHP files in the root directory correctly check if "$rep == null" before accessing "$rep->..." . The only errors where filedetails.php (websvnphp#192) and dl.php (websvnphp#194)
michael-o
approved these changes
Sep 30, 2023
michael-o
approved these changes
Sep 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following bug:
Calling dl.php?repname=xxx where xxx is a non-existing repo causes the error "Call to a member function isDownloadAllowed() on null" .
Note: I have now verified that all PHP files in the root directory correctly check for "$rep == null" before accessing "$rep->..." . The only problems were filedetails.php (#192) and dl.php (#194) which are now fixed.