Always UTF-8 encode filename parameter in Content-Disposition header#158
Closed
Always UTF-8 encode filename parameter in Content-Disposition header#158
Conversation
Contributor
|
While this looks good to me, how does it close #155 and the wrongly used HTML-escape? Looks like two different aspects of the problem to me. Forwarding HTML-escapes is still wrong. |
Member
Author
Since we don't know that passed filename will or will not contain ASCII-only chartacters it is the safest approach to always encode the filename. This closes #158
459417a to
f28addf
Compare
ams-tschoening
approved these changes
Feb 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we don't know that passed filename will or will not contain ASCII-only
chartacters it is the safest approach to always encode the filename.
This closes #158