Revert default AudioOptions change for webrtc_voice_engine.cc on Android#205
Merged
davidliu merged 1 commit intom137_releasefrom Nov 18, 2025
Merged
Revert default AudioOptions change for webrtc_voice_engine.cc on Android#205davidliu merged 1 commit intom137_releasefrom
davidliu merged 1 commit intom137_releasefrom
Conversation
Contributor
Author
hiroshihorie
approved these changes
Nov 18, 2025
cloudwebrtc
pushed a commit
that referenced
this pull request
Feb 2, 2026
…oid (#205) These default values got changed from true to false in #178. On Android, the way the audio options are set is fairly janky, and actually relied on these initially defaulting to true. I'm not sure if other non iOS platforms rely on these initial default values as well, but that's something to be aware of for those platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These default values got changed from true to false in #178. On Android, the way the audio options are set is fairly janky, and actually relied on these initially defaulting to true.
I'm not sure if other non iOS platforms rely on these initial default values as well, but that's something to be aware of for those platforms.