Skip to content

Custom audio input for Android#154

Merged
davidliu merged 4 commits intom125_releasefrom
dl/custom_audio
Oct 31, 2024
Merged

Custom audio input for Android#154
davidliu merged 4 commits intom125_releasefrom
dl/custom_audio

Conversation

@davidliu
Copy link
Copy Markdown
Contributor

No description provided.

@davidliu davidliu requested a review from cloudwebrtc October 30, 2024 09:03
Copy link
Copy Markdown
Member

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidliu davidliu merged commit 543121b into m125_release Oct 31, 2024
@davidliu davidliu deleted the dl/custom_audio branch October 31, 2024 03:33
hiroshihorie added a commit that referenced this pull request Dec 9, 2024
commit 102940838f859941a41b2f3062d4eb8a61be6414
Author: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>
Date:   Thu Dec 5 15:27:34 2024 +0700

    audio engine 1

commit d31187b
Author: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>
Date:   Thu Dec 5 15:26:38 2024 +0700

    Connect voice engine mute to adm

commit 3df68d4
Author: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>
Date:   Fri Oct 11 20:41:44 2024 +0900

    Revert "Stop recording on mute (turn off mic indicator) (#55)"

    This reverts commit c0209ef.

commit b99fd2c
Author: Michael Sloan <mgsloan@gmail.com>
Date:   Mon Dec 2 18:59:22 2024 -0700

    Use `rtc::ToString` instead of `std::to_string` in `SocketAddress::PortAsString()` (#156)

    Justification for this change is that `std::to_string` should be avoided
    as it uses the user's locale and calls to it get serialized, which is
    bad for concurrency.

    My actual motivation for this is quite bizarre. Before this change, with
    Zed's use of the LiveKit Rust SDK, I was getting connection strings that
    were not valid utf-8, instead having a port of
    `3\u0000\u0000\u001c\u0000`. I have not figured out how that could
    happen or why this change fixes it.

commit 543121b
Author: davidliu <davidliu@deviange.net>
Date:   Wed Oct 30 20:33:46 2024 -0700

    Custom audio input for Android (#154)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants