Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: webrtc-sdk/webrtc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 46226b5
Choose a base ref
...
head repository: webrtc-sdk/webrtc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 543121b
Choose a head ref
  • 20 commits
  • 33 files changed
  • 5 contributors

Commits on Jun 14, 2024

  1. Configuration menu
    Copy the full SHA
    7e8c15c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c600b00 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Configuration menu
    Copy the full SHA
    7534c15 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    432a28b View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Fix webrtc_voice_engine not notifying mute change (#128)

    Looks like this line was missed during the m125 update.
    
    
    272127d#diff-56f5e0c459b287281ef3b0431d3f4129e8e4be4c6955d845bcb22210f08b7ba5R2289
    
    Adding it back in so that mic is properly released when muted.
    davidliu authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    a5b6625 View commit details
    Browse the repository at this point in the history
  2. android: Allow for skipping checking the audio playstate if needed (#129

    )
    
    Pausing/stopping the audio track can lead to a race condition against
    the AudioTrackThread due to this assert. Normally this is fine since
    directly pausing/stopping isn't possible, but user is using reflection
    to workaround another audio issue (muted participants still have a
    sending audio stream which keeps the audio alive, affecting global sound
    if in the background).
    
    Not a full fix, as would like to manually control the audio track
    directly (needs a bigger fix to handle proper synchronization before
    allowing public access), but this will work through reflection (user
    takes responsibility for usage).
    davidliu authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    7ddfc43 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Allow to pass in capture session to RTCCameraVideoCapturer (#132)

    Expose initializers to pass in capture session to RTCCameraVideoCapturer
    so we can use AVCaptureMultiCamSession etc to capture front and back
    simultaneously for iOS.
    hiroshihorie authored Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0ef336a View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Fix NetworkMonitor race condition when dispatching native observers (#…

    …135)
    
    There is a race condition in NetworkMonitor where native observers may
    be removed concurrently with a notification being dispatched, leading to
    a dangling pointer dereference (trying to dispatch an observer that was
    already removed and destroyed), and from there a crash with access
    violation.
    
    By ensuring dispatching to native observers is done within the
    synchronization lock that guards additions/removals of native observers
    protects against this race condition. Since native observers callbacks
    are posted to the networking thread in the C++ side anyway, there should
    be no risk of deadlock/starvation due to long-running observers.
    
    Bug: webrtc:15837
    Change-Id: Id2b788f102dbd25de76ceed434c4cd68aa9a569e
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/338643
    Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
    Commit-Queue: Harald Alvestrand <hta@webrtc.org>
    Reviewed-by: Harald Alvestrand <hta@webrtc.org>
    Cr-Commit-Position: refs/heads/main@{#42256}
    
    Co-authored-by: Guy Hershenbaum <hershi@meta.com>
    davidliu and Guy Hershenbaum authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5778782 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Support for Vision Pro (#131)

    TODO:
    - [x]  fix compile for RTCCameraVideoCapturer
    - [ ]  fix RTCMTLRenderer ?
    
    ---------
    
    Co-authored-by: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>
    cloudwebrtc and hiroshihorie authored Aug 12, 2024
    1 Configuration menu
    Copy the full SHA
    6bb47f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2024

  1. Multicam support (#137)

    TODO: 
    - [x] Return `.systemPreferredCamera` for devices (visionOS only).
    - [x] Use `AVCaptureMultiCamSession` only if `isMultiCamSupported` is
    true.
    - [x] Silence statusBarOrientation warning.
    
    ---------
    
    Co-authored-by: duanweiwei1982@gmail.com <duanweiwei1982@gmail.com>
    hiroshihorie and cloudwebrtc authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    c852b0e View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. tvOS support (#139)

    17.0+ only atm
    
    ---------
    
    Co-authored-by: cloudwebrtc <duanweiwei1982@gmail.com>
    hiroshihorie and cloudwebrtc authored Aug 22, 2024
    Configuration menu
    Copy the full SHA
    158cde8 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Configuration menu
    Copy the full SHA
    14db92e View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2024

  1. Configuration menu
    Copy the full SHA
    cdc3bba View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Allow software AEC for Simulator (#143)

    ~Allow to use "googEchoCancellation" constraint for software AEC.
    For devices "googEchoCancellation" should be false to use
    VoiceProcessingIO.~
    hiroshihorie authored Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3c17c96 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7662c43 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Configuration menu
    Copy the full SHA
    d84b36e View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Configuration menu
    Copy the full SHA
    0ae5688 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Change audio renderer output format (#149)

    Instead of converting to Float, output original Int data without
    conversion.
    Output the raw format and convert when required.
    hiroshihorie authored Oct 19, 2024
    Configuration menu
    Copy the full SHA
    c38ce7f View commit details
    Browse the repository at this point in the history
  2. Fixed issue with missing network interfaces on iOS (#151)

    Related issue: #148
    Cherry-pick :
    https://webrtc.googlesource.com/src/+/fea60ef8e72fb17b4f8a5363aff7e63ab8027b4f
    
    Fixed issue with network interfaces due to a missing return value in the
    "nw_path_enumerate_interfaces(...)" block. Exposed in iOS 18,
    RTCNetworkMonitor::initWithObserver will only enumerate the first
    interface, instead of all device interfaces
    
    Bug: webrtc:359245764
    Change-Id: Ifb9f28c33306c0096476a4afb0cdb4d734e87b2c
    Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/359541
    Auto-Submit: Corby <corby.hoback@gmail.com>
    Commit-Queue: Jonas Oreland <jonaso@webrtc.org>
    Reviewed-by: Kári Helgason <kthelgason@webrtc.org>
    Reviewed-by: Jonas Oreland <jonaso@webrtc.org>
    Cr-Commit-Position: refs/heads/main@{#42818}
    
    Co-authored-by: Corby Hoback <corby.hoback@gmail.com>
    hiroshihorie and Corby Hoback authored Oct 19, 2024
    Configuration menu
    Copy the full SHA
    cd6792e View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Configuration menu
    Copy the full SHA
    543121b View commit details
    Browse the repository at this point in the history
Loading