Merged
Conversation
alvestrand
approved these changes
Oct 17, 2023
Contributor
|
Still chromedriver woes.... |
b79228d to
8c91c47
Compare
Collaborator
Author
|
Without the chromedriver dependency selenium found the preinstalled chromedriver. |
since this gets automagically installed by Selenium these days. Also remove chromedriver symlink from githubs worker image so that selenium downloads a matching version rather than relying on the preinstalled version which might not be compatible with the browser
8c91c47 to
d872d8b
Compare
Collaborator
Author
|
I wonder about geckodriver but... separate PR and it hasn't shown any issues. |
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Oct 18, 2023
follow-up to webrtc#1631
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Oct 18, 2023
follow-up to webrtc#1631, let selenium do the downloading
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Oct 18, 2023
follow-up to webrtc#1631, let selenium do the downloading
fippo
added a commit
to fippo/webrtc
that referenced
this pull request
Oct 18, 2023
follow-up to webrtc#1631, let selenium do the downloading
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since this gets automagically installed by Selenium these days