Ensure seed files are deleted on org delete #2919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikreymer
added a commit
that referenced
this pull request
Oct 22, 2025
…en deleted: - in seed cleanup, catch if org doesn't exist and attempt to delete file directly - add delete_file_from_default_storage() to allow deleting left-over seed files, assuming they are stored in default storage - side effect of #2918, which will be fixed in #2919 - no need for migration, as will be picked up existing cleanup seed files job
ikreymer
added a commit
that referenced
this pull request
Oct 22, 2025
…ted (#2920) - in seed cleanup, catch if org doesn't exist and attempt to delete file directly - add delete_file_from_default_storage() to allow deleting left-over seed files, assuming they are stored in default storage - side effect of #2918, which will be fixed in #2919 - no need for migration, as will be picked up existing cleanup seed files job
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2918
Testing
I've tested that this works correctly and that the seed files are left behind on org delete in current main.