Fix crawl running filter being passed incorrectly to backend #2904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe399a5 to
0e4bf97
Compare
This reverts commit 2558147.
previously the parameter was treated as optional boolean but the logic treated the absence of the parameter as false, which differs from other parameters. now it's explicitly set to true only when the parameter is present and equals "true", and undefined otherwise.
0e4bf97 to
4a48ef6
Compare
ikreymer
added a commit
that referenced
this pull request
Oct 17, 2025
…2905) Quick fix for an issue where the default state of the crawl running filter on the workflows list page was incorrectly filtering out running crawls. (1.19.4 patch release) Co-authored-by: Emma Segal-Grossman <hi@emma.cafe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for an issue where the default state of the crawl running filter on the workflows list page was incorrectly filtering out running crawls.