Skip to content

chore(deps): update package-lock.json#2289

Merged
hiroppy merged 1 commit intomasterfrom
feature/update-package-lock
Oct 22, 2019
Merged

chore(deps): update package-lock.json#2289
hiroppy merged 1 commit intomasterfrom
feature/update-package-lock

Conversation

@hiroppy
Copy link
Copy Markdown
Member

@hiroppy hiroppy commented Oct 22, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no

Motivation / Use-Case

                                                                                
                       === npm audit security report ===                        
                                                                                
# Run  npm update https-proxy-agent --depth 2  to resolve 1 vulnerability
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ Machine-In-The-Middle                                        │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ https-proxy-agent                                            │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ puppeteer [dev]                                              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ puppeteer > https-proxy-agent                                │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1184                            │
└───────────────┴──────────────────────────────────────────────────────────────┘

Breaking Changes

Additional Info

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 22, 2019 •
edited
Loading

Codecov Report

Merging #2289 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2289   +/-   ##
=======================================
  Coverage   93.92%   93.92%           
=======================================
  Files          34       34           
  Lines        1284     1284           
  Branches      366      369    +3     
=======================================
  Hits         1206     1206           
+ Misses         77       71    -6     
- Partials        1        7    +6
Impacted Files Coverage Δ
client-src/clients/WebsocketClient.js 57.89% <0%> (ø) ⬆️
client-src/clients/SockJSClient.js 61.53% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1d4d7f...8e7e83a. Read the comment docs.

@hiroppy hiroppy merged commit 4abc8c3 into master Oct 22, 2019
@hiroppy hiroppy deleted the feature/update-package-lock branch October 22, 2019 15:50
digitaljohn pushed a commit to signal-noise/webpack-dev-server that referenced this pull request Oct 23, 2019
@hiroppy
chore(deps): update package-lock.json (webpack#2289)
58f9f24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@knagaitsev knagaitsev Awaiting requested review from knagaitsev

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hiroppy @alexander-akait