Hotfix/testing#8
Merged
Merged
Conversation
* feat: testing-and-inquirer Commit allows further testing and integration with inquirer and jest for our TDD approach. Regex could be changed to have specific test names for our purposes. * feat: installed rx and test on travis Installed rxJS and our tests are running in the travis validations. * hotfix: Change name Changes name to better reflect its usage. * feat: new test suites Integrated new test suites and trying to get it work nicely with observable sequences. * fix - Adds changes to observable questions * fix - Try to pass the build * hotfix: New test pattern Manually mock inquirer, allows clean test stdin and a faster testing procedure. * hotfix: Travis stuff * Hotfix: travis * hotfix: yarn * hotfix: travis * hotfix: new travis * hotfix * hotfix2 * hotfix: Use ES6 + prepare to squash
Fix the build
pksjce
approved these changes
Dec 20, 2016
evenstensberg
pushed a commit
that referenced
this pull request
Dec 21, 2016
Hotfix/testing (#8) * Jest and Inquirer Integration [WIP] (#5) * feat: testing-and-inquirer Commit allows further testing and integration with inquirer and jest for our TDD approach. Regex could be changed to have specific test names for our purposes. * feat: installed rx and test on travis Installed rxJS and our tests are running in the travis validations. * hotfix: Change name Changes name to better reflect its usage. * feat: new test suites Integrated new test suites and trying to get it work nicely with observable sequences. * fix - Adds changes to observable questions * fix - Try to pass the build * hotfix: New test pattern Manually mock inquirer, allows clean test stdin and a faster testing procedure. * hotfix: Travis stuff * Hotfix: travis * hotfix: yarn * hotfix: travis * hotfix: new travis * hotfix * hotfix2 * hotfix: Use ES6 + prepare to squash * Fix the build Project Restructure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes to testing for travis with the work of @pksjce has done, this is basically the same PR. Will integrate Jest and Inquirer.
Did you add tests for your changes?
Yass.
Summary
Continuation from #5 , tests failed and now they are fixed. Allows further work to be done on the current build.