Merged
Conversation
yeoman-generator to v5
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #3421 +/- ##
==========================================
+ Coverage 91.61% 91.78% +0.16%
==========================================
Files 22 22
Lines 1587 1583 -4
Branches 447 446 -1
==========================================
- Hits 1454 1453 -1
+ Misses 133 130 -3
Continue to review full report at Codecov.
|
snitin315
commented
Sep 24, 2022
Comment on lines
-22
to
-34
| if (!existsSync(this.generationPath)) { | ||
| this.cli.logger.log( | ||
| `${this.cli.colors.blue( | ||
| "ℹ INFO ", | ||
| )} supplied generation path doesn't exist, required folders will be created.`, | ||
| ); | ||
| try { | ||
| mkdirSync(this.generationPath, { recursive: true }); | ||
| } catch (error) { | ||
| this.cli.logger.error(`Failed to create directory.\n ${error}`); | ||
| process.exit(2); | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
This is now handled by the yeoman-generator itself. I've updated the test cases accordingly.
94afa19 to
dbbc846
Compare
snitin315
commented
Sep 24, 2022
Comment on lines
+9
to
+10
| // eslint-disable-next-line @typescript-eslint/no-var-requires | ||
| Object.assign(Generator.prototype, require("yeoman-generator/lib/actions/install")); |
Member
Author
There was a problem hiding this comment.
Install action is deprecated and is not included by default
dbbc846 to
62649f2
Compare
alexander-akait
approved these changes
Sep 25, 2022
Member
alexander-akait
left a comment
There was a problem hiding this comment.
Looks good, please rebase
62649f2 to
11ad91d
Compare
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @alexander-akait Please review the new changes. |
Member
Author
|
Rebased. |
snitin315
added a commit
that referenced
this pull request
Oct 22, 2022
snitin315
added a commit
that referenced
this pull request
Nov 6, 2022
snitin315
added a commit
that referenced
this pull request
Nov 8, 2022
alexander-akait
pushed a commit
that referenced
this pull request
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
chore
Did you add tests for your changes?
No.
If relevant, did you update the documentation?
No.
Summary
update
yeoman-generatorto v5.Does this PR introduce a breaking change?
No.
Other information
No/