Skip to content

refactor!: the minimun supported webpack-dev-server version is v4.0.0#3353

Merged
snitin315 merged 2 commits intonextfrom
refactor/drop-webpack-dev-server-3
Jul 29, 2022
Merged

refactor!: the minimun supported webpack-dev-server version is v4.0.0#3353
snitin315 merged 2 commits intonextfrom
refactor/drop-webpack-dev-server-3

Conversation

@snitin315
Copy link
Member

What kind of change does this PR introduce?
refactor

Did you add tests for your changes?
Already present.

If relevant, did you update the documentation?
No.

Summary

Drop support for webpack-dev-server v3.

Does this PR introduce a breaking change?
BREAKING CHANGE: The minimum supported webpack-dev-server version is v4.0.0

Other information
No

@snitin315 snitin315 requested a review from a team as a code owner July 29, 2022 09:18
@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #3353 (00bf4a1) into next (0dba3db) will increase coverage by 2.23%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #3353      +/-   ##
==========================================
+ Coverage   90.83%   93.06%   +2.23%     
==========================================
  Files          22       22              
  Lines        1669     1616      -53     
  Branches      479      457      -22     
==========================================
- Hits         1516     1504      -12     
+ Misses        153      112      -41     
Impacted Files Coverage Δ
packages/serve/src/index.ts 78.94% <57.14%> (+17.86%) ⬆️
packages/webpack-cli/src/webpack-cli.ts 95.17% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dba3db...00bf4a1. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but CI is broken, let's fix

@snitin315
Copy link
Member Author

It looks like a random failure, the re-run was successful.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge

@snitin315 snitin315 merged commit 98a6fd0 into next Jul 29, 2022
@snitin315 snitin315 deleted the refactor/drop-webpack-dev-server-3 branch July 29, 2022 15:27
snitin315 added a commit that referenced this pull request Sep 10, 2022
…0.0` (#3353)

* refactor!: the minimun supported webpack-dev-server version in v4.0.0

* refactor: remove unused type
snitin315 added a commit that referenced this pull request Sep 17, 2022
…0.0` (#3353)

* refactor!: the minimun supported webpack-dev-server version in v4.0.0

* refactor: remove unused type
snitin315 added a commit that referenced this pull request Sep 24, 2022
…0.0` (#3353)

* refactor!: the minimun supported webpack-dev-server version in v4.0.0

* refactor: remove unused type
snitin315 added a commit that referenced this pull request Sep 24, 2022
…0.0` (#3353)

* refactor!: the minimun supported webpack-dev-server version in v4.0.0

* refactor: remove unused type
snitin315 added a commit that referenced this pull request Oct 8, 2022
…0.0` (#3353)

* refactor!: the minimun supported webpack-dev-server version in v4.0.0

* refactor: remove unused type
snitin315 added a commit that referenced this pull request Oct 22, 2022
…0.0` (#3353)

* refactor!: the minimun supported webpack-dev-server version in v4.0.0

* refactor: remove unused type
snitin315 added a commit that referenced this pull request Nov 6, 2022
…0.0` (#3353)

* refactor!: the minimun supported webpack-dev-server version in v4.0.0

* refactor: remove unused type
snitin315 added a commit that referenced this pull request Nov 8, 2022
…0.0` (#3353)

* refactor!: the minimun supported webpack-dev-server version in v4.0.0

* refactor: remove unused type
alexander-akait pushed a commit that referenced this pull request Nov 15, 2022
…0.0` (#3353)

* refactor!: the minimun supported webpack-dev-server version in v4.0.0

* refactor: remove unused type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants