fix(webpack-cli): add an option for preventing interpret by shuta13 · Pull Request #3329 · webpack/webpack-cli

shuta13 · 2022-07-06T06:12:00Z

What kind of change does this PR introduce?

A kind of bugfix.

Did you add tests for your changes?

Yes.

If relevant, did you update the documentation?

Users can check this option with the webpack --help.

Summary

Fixed #3195

Does this PR introduce a breaking change?

No.

Other information

linux-foundation-easycla · 2022-07-06T06:12:07Z

The committers listed above are authorized under a signed CLA.

✅ login: shuta13 / name: Shuta Hirai (6cbe9d3)

packages/webpack-cli/src/webpack-cli.ts

shuta13 · 2022-07-11T01:30:44Z

@snitin315 ↑ Please check those.

OPTIONS.md

packages/webpack-cli/src/webpack-cli.ts

test/build/config-format/typescript/typescript.test.js

rishabh3112

Left a suggestion to complete the testing cases.

test/build/config-format/typescript/typescript.test.js

anshumanv

いい感じ

OPTIONS.md

Co-authored-by: Anshuman Verma <anshu.av97@gmail.com>

shuta13 · 2022-07-22T05:23:07Z

@snitin315

Sorry for the late reply. I added the way to remove --require from yarn test:coverage without testing error : 645bb7b

Please check and rerun the CI workflows.

anshumanv · 2022-07-22T05:37:09Z

スタートしました〜

codecov · 2022-07-22T05:56:00Z

Codecov Report

Merging #3329 (c1763f0) into master (58503be) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3329   +/-   ##
=======================================
  Coverage   92.26%   92.27%           
=======================================
  Files          23       23           
  Lines        1733     1734    +1     
  Branches      519      520    +1     
=======================================
+ Hits         1599     1600    +1     
  Misses        134      134

Impacted Files	Coverage Δ
packages/webpack-cli/src/webpack-cli.ts	`93.96% <100.00%> (+<0.01%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58503be...c1763f0. Read the comment docs.

shuta13 · 2022-07-22T05:59:58Z

I forgot to update snapshots when testing with dev-server@3. : https://github.com/webpack/webpack-cli/runs/7462801069?check_suite_focus=true#step:9:96

I'll fix...

anshumanv · 2022-07-22T06:03:09Z

It seems other tests are passing though which is good

shuta13 · 2022-07-22T07:31:06Z

@anshumanv

It seems other tests are passing though which is good

Thx. But, I'm worried about other contributors may be confused with the CI failing even though they don't make any changes. So, I update snapshots 🙏 : c1763f0

anshumanv · 2022-07-22T07:42:16Z

Thanks I've started CI, let's see if everything passes this time 🤞

snitin315

LGTM. Thanks for contributing ⭐.

/cc @alexander-akait

alexander-akait

@snitin315 After merge we will need to rebase the next branch, this can be a problem, maybe we will merge this directly in next?

snitin315 · 2022-07-25T10:44:40Z

@alexander-akait Yes, let's point this PR to the next branch.

alexander-akait

Feel free to merge

* fix(webpack-cli): add an option for preventing interpret * fix: define the option for built-in flags * docs: add descriptions of the option * refactor: rename `--config-registered` to `--disable-interpret` * fix: change conditional statement * refactor: standalone test * test: use `--disable-interpret` without transpilation * docs: fix the description Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> * refactor: built-in options type Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: re-update snapshots * fix: add double quote Co-authored-by: Nitin Kumar <snitin315@gmail.com> * test: update snapshots for webpack4 * chore: remove `--require` from `test:coverage` * test: update snapshots Co-authored-by: Anshuman Verma <anshu.av97@gmail.com> Co-authored-by: Nitin Kumar <snitin315@gmail.com>

fix(webpack-cli): add an option for preventing interpret

6cbe9d3

shuta13 requested a review from a team as a code owner July 6, 2022 06:12

webpack-bot added the PR: unreviewed label Jul 6, 2022

shuta13 commented Jul 6, 2022

View reviewed changes

packages/webpack-cli/src/webpack-cli.ts Outdated Show resolved Hide resolved

shuta13 added 2 commits July 8, 2022 12:07

fix: define the option for built-in flags

1237319

docs: add descriptions of the option

7c6d3fa

shuta13 requested a review from snitin315 July 8, 2022 08:20

alexander-akait reviewed Jul 11, 2022

View reviewed changes

OPTIONS.md Outdated Show resolved Hide resolved

refactor: rename --config-registered to --disable-interpret

79f61c9

shuta13 requested a review from alexander-akait July 13, 2022 06:42

alexander-akait reviewed Jul 13, 2022

View reviewed changes

packages/webpack-cli/src/webpack-cli.ts Outdated Show resolved Hide resolved

fix: change conditional statement

d4673f1

shuta13 requested a review from alexander-akait July 14, 2022 08:59

anshumanv reviewed Jul 14, 2022

View reviewed changes

test/build/config-format/typescript/typescript.test.js Outdated Show resolved Hide resolved

rishabh3112 requested changes Jul 17, 2022

View reviewed changes

test/build/config-format/typescript/typescript.test.js Outdated Show resolved Hide resolved

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Jul 17, 2022

shuta13 added 2 commits July 18, 2022 07:37

refactor: standalone test

46eb622

test: use --disable-interpret without transpilation

771f7a3

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Jul 17, 2022

shuta13 requested review from anshumanv and rishabh3112 July 17, 2022 22:58

anshumanv previously approved these changes Jul 18, 2022

View reviewed changes

OPTIONS.md Outdated Show resolved Hide resolved

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Jul 18, 2022

docs: fix the description

504ca58

Co-authored-by: Anshuman Verma <anshu.av97@gmail.com>

shuta13 dismissed anshumanv’s stale review via 504ca58 July 18, 2022 07:34

shuta13 requested a review from snitin315 July 22, 2022 06:08

test: update snapshots

c1763f0

snitin315 approved these changes Jul 22, 2022

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Jul 22, 2022

anshumanv approved these changes Jul 22, 2022

View reviewed changes

rishabh3112 approved these changes Jul 22, 2022

View reviewed changes

alexander-akait approved these changes Jul 25, 2022

View reviewed changes

snitin315 changed the base branch from master to next July 25, 2022 10:44

alexander-akait approved these changes Jul 25, 2022

View reviewed changes

snitin315 merged commit 222c96d into webpack:next Jul 25, 2022

alexander-akait mentioned this pull request Sep 7, 2022

no way to prevent interpret from transpiling the config, even if another tool has been configured #3195

Closed

Uh oh!

Conversation

shuta13 commented Jul 6, 2022

Uh oh!

linux-foundation-easycla bot commented Jul 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

shuta13 commented Jul 11, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rishabh3112 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anshumanv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shuta13 commented Jul 22, 2022

Uh oh!

anshumanv commented Jul 22, 2022

Uh oh!

codecov bot commented Jul 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shuta13 commented Jul 22, 2022

Uh oh!

anshumanv commented Jul 22, 2022

Uh oh!

shuta13 commented Jul 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anshumanv commented Jul 22, 2022

Uh oh!

snitin315 left a comment

Choose a reason for hiding this comment

Uh oh!

alexander-akait left a comment

Choose a reason for hiding this comment

Uh oh!

snitin315 commented Jul 25, 2022

Uh oh!

alexander-akait left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

linux-foundation-easycla bot commented Jul 6, 2022 •

edited

Loading

codecov bot commented Jul 22, 2022 •

edited

Loading

shuta13 commented Jul 22, 2022 •

edited

Loading