fix(json): json parameter now enables modules#242
Merged
evenstensberg merged 1 commit intoJan 13, 2018
Conversation
Member
|
@axe312ger could you add a test to this? Also, print the failing tests here as a screenshot :) |
Contributor
Author
|
Failed in node 6 only via a timeout. Maybe just retrigger this one build? |
Contributor
|
I gave it a rebuild, let's see how it turns |
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ooflorent
approved these changes
Jan 12, 2018
evenstensberg
approved these changes
Jan 13, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Nope, wanted to extend tests for
--jsonbut couldn't find any. Should I do so? (tests are actually failing locally for me, even without my change)If relevant, did you update the documentation?
nope, not needed IMHO
Summary
Fixes webpack/webpack#6307
Does this PR introduce a breaking change?
nope
Other information