🦋 Changeset detected

Latest commit: 288c500

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This PR is packaged and the instant preview is available (5ecc58d).

Install it locally:

• npm

npm i -D webpack@https://pkg.pr.new/webpack@5ecc58d

• yarn

yarn add -D webpack@https://pkg.pr.new/webpack@5ecc58d

• pnpm

pnpm add -D webpack@https://pkg.pr.new/webpack@5ecc58d

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing asset-side-effect-free (288c500) with main (fe48655)¹}

Summary

✅ 72 untouched benchmarks

Looks like we need to fix tests, but code looks good

We should consider a better approach for setting factoryMeta. It is assigned at parsing stage right now, it will lead to some issue when working with both disk and memory caching, and cause module.factoryMeta can't be properly restored.

@hai-x Yeah, we have the same problem with renaming modules, alternative solution - make builtMeta and buildInfo as getters, but will be glad to have a hook to setup it

I use createModuleClass here cause it will be called at the factory stage. And it also aligns with our goal of creating asset modules via newly AssetModule(it's still TODO).

Thanks for review. It such one good idea to use __webpack_modules__.

Just a heads up: this broke our build. We marked fonts to include in the build with side-effect only imports from our code

import "~/assets/my-font.woff"

and as expected, this caused the font not to be copied anymore.

I think there should be extra documentation in https://webpack.js.org/guides/asset-modules mentionning this can be forced using

      {
        test: /\.(woff|woff2)$/,
        generator: {
          filename: 'fonts/[name][ext]',
        },
        type: 'asset/resource',
        sideEffects: true,
      },

@GerkinDev We should fix it, it is a bug

/cc @hai-x Let's do mark them as side effect free for side-effect only imports

Just a heads up: this broke our build. We marked fonts to include in the build with side-effect only imports from our code

import "~/assets/my-font.woff"

and as expected, this caused the font not to be copied anymore.

I think there should be extra documentation in https://webpack.js.org/guides/asset-modules mentionning this can be forced using

      {
        test: /\.(woff|woff2)$/,
        generator: {
          filename: 'fonts/[name][ext]',
        },
        type: 'asset/resource',
        sideEffects: true,
      },

@GerkinDev We should fix it, it is a bug

/cc @hai-x Let's do mark them as side effect free for side-effect only imports