Skip to content

refactor: avoid module variable conflict in __webpack_module__ API#20265

Merged
alexander-akait merged 1 commit intomainfrom
issue-20264
Dec 26, 2025
Merged

refactor: avoid module variable conflict in __webpack_module__ API#20265
alexander-akait merged 1 commit intomainfrom
issue-20264

Conversation

@xiaoxiaojx
Copy link
Member

Summary
Fixes #20264

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
Yes

Does this PR introduce a breaking change?
No

If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2025

🦋 Changeset detected

Latest commit: 21da905

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
webpack Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2025

This PR is packaged and the instant preview is available (d2a124d).

Install it locally:

  • npm
npm i -D webpack@https://pkg.pr.new/webpack@d2a124d
  • yarn
yarn add -D webpack@https://pkg.pr.new/webpack@d2a124d
  • pnpm
pnpm add -D webpack@https://pkg.pr.new/webpack@d2a124d

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 22, 2025

CodSpeed Performance Report

Merging #20265 will not alter performance

Comparing issue-20264 (21da905) with main (f21d135)

Summary

✅ 72 untouched

@xiaoxiaojx xiaoxiaojx changed the title fix: rename moduleArgument when module is declared in current scope [WIP] fix: rename moduleArgument when module is declared in current scope Dec 23, 2025
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, is it ready to merge? Because there is WIP

@xiaoxiaojx xiaoxiaojx closed this Dec 25, 2025
@xiaoxiaojx xiaoxiaojx deleted the issue-20264 branch December 25, 2025 17:14
@xiaoxiaojx xiaoxiaojx restored the issue-20264 branch December 25, 2025 17:14
@xiaoxiaojx xiaoxiaojx reopened this Dec 25, 2025
@xiaoxiaojx xiaoxiaojx changed the title [WIP] fix: rename moduleArgument when module is declared in current scope refactor: avoid module variable conflict in __webpack_module__ API Dec 25, 2025
@xiaoxiaojx xiaoxiaojx force-pushed the issue-20264 branch 2 times, most recently from 067e176 to 33cedcc Compare December 25, 2025 17:51
@alexander-akait alexander-akait merged commit d2a124d into main Dec 26, 2025
51 of 52 checks passed
@alexander-akait alexander-akait deleted the issue-20264 branch December 26, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

__webpack_module__ is rewritten to module, causing identifier collision with user-defined const module

2 participants