fix: delay HMR accept dependencies to preserve import attributes #20124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #20124 will not alter performanceComparing Summary
|
9d29514 to
0355b05
Compare
| super(); | ||
| this.request = request; | ||
| this.userRequest = request; | ||
| this.sourceOrder = sourceOrder; |
Member
There was a problem hiding this comment.
Don't forget to write it in serilizer and deserilizer
6923e0e to
8debd3d
Compare
alexander-akait
approved these changes
Nov 14, 2025
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The root cause of this issue is that both ImportDependency and ModuleHotAcceptDependency can be used to generate a module (e.g., ./info.json). ImportDependency includes import attributes, but ModuleHotAcceptDependency does not. If ModuleHotAcceptDependency appears first, the generated module (./info.json) will lack import attributes, which means it can’t match type: "json". As a result, it gets treated as a JavaScriptModule, leading to a parsing error.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Nothing