Skip to content

fix(warnings): update import.meta warning messages for clarity#19961

Merged
alexander-akait merged 1 commit intowebpack:mainfrom
manbearwiz:patch-1
Sep 30, 2025
Merged

fix(warnings): update import.meta warning messages for clarity#19961
alexander-akait merged 1 commit intowebpack:mainfrom
manbearwiz:patch-1

Conversation

@manbearwiz
Copy link
Contributor

Summary

This improves the import.meta direct access warning. I find the current warning is sorta unclear as to what "Accessing import.meta directly" means in this context. I've updated it to clarify that import.meta cannot be used as a standalone expression because of static analysis requirements and provides clear examples of correct usage.

What kind of change does this PR introduce?

Just logs/docs.

Did you add tests for your changes?

Updated. None added

Does this PR introduce a breaking change?

No

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Not relevant.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 30, 2025

CLA Signed

  • ✅login: manbearwiz / name: Kevin Brey / (e3121d7)

The committers listed above are authorized under a signed CLA.

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 30, 2025

CodSpeed Performance Report

Merging #19961 will degrade performances by 63.65%

Comparing manbearwiz:patch-1 (e3121d7) with main (14c813a)

Summary

⚡ 1 improvement
❌ 1 regression
✅ 40 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 42 ms 115.6 ms -63.65%
benchmark "devtool-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 126.9 ms 44.7 ms ×2.8

@alexander-akait alexander-akait merged commit 3c08fd1 into webpack:main Sep 30, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants