Skip to content

fix: integrity in http-url test#19954

Merged
alexander-akait merged 3 commits intomainfrom
fix-integrity
Sep 29, 2025
Merged

fix: integrity in http-url test#19954
alexander-akait merged 3 commits intomainfrom
fix-integrity

Conversation

@hai-x
Copy link
Member

@hai-x hai-x commented Sep 27, 2025

Summary

What kind of change does this PR introduce?

Fixes https://github.com/webpack/webpack/actions/runs/18043508600/job/51348453106.

After SHA-512 hashing and Base64 encoding to README.md file, the result should be 0ZvAGT9BNo7wDRzhVolbFzyjKiO77AZnNMcuIrOFrk5DIlwLa0QTz48mERI9Z5KhoIIUBNIMMTi10ZI8aWeMnQ==

Did you add tests for your changes?

Existing

Does this PR introduce a breaking change?

No

If relevant, what needs to be documented once your changes are merged or what have you already documented?

No

@hai-x
Copy link
Member Author

hai-x commented Sep 27, 2025

Ideally, we should change those http url paths to the file which are infrequently updated. It can mostly prevent impacting out tests. :)

@hai-x hai-x marked this pull request as ready for review September 27, 2025 14:32
@codspeed-hq
Copy link

codspeed-hq bot commented Sep 27, 2025

CodSpeed Performance Report

Merging #19954 will degrade performances by 36.33%

Comparing fix-integrity (bd37a1a) with main (d9121b3)

Summary

⚡ 1 improvement
❌ 2 regressions
✅ 39 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
benchmark "devtool-eval", scenario '{"name":"mode-development","mode":"development"}' 335.8 ms 241.4 ms +39.09%
benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 84.3 ms 123.7 ms -31.83%
benchmark "devtool-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 45.3 ms 71.1 ms -36.33%

@alexander-akait
Copy link
Member

Ideally, we should change those http url paths to the file which are infrequently updated. It can mostly prevent impacting out tests. :)

Feel free to do it 👍

@alexander-akait alexander-akait merged commit 042bf86 into main Sep 29, 2025
81 of 82 checks passed
@alexander-akait alexander-akait deleted the fix-integrity branch September 29, 2025 16:17
@hai-x hai-x mentioned this pull request Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants