Add collectDestructuringAasignmentProperties hook to only collect for specific expression#19811
Merged
alexander-akait merged 2 commits intowebpack:mainfrom Aug 17, 2025
Merged
Conversation
… specific expression
CodSpeed Performance ReportMerging #19811 will degrade performances by 95.23%Comparing Summary
Benchmarks breakdown
|
Member
|
@ahabhgk fyi CI failures on Node.js v24.x are due to a known upstream regression in VM module linking (v24.6+). Please ignore these failures for now :) |
alexander-akait
approved these changes
Aug 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
collectDestructuringAasignmentPropertieshook to only collectdestructuringAssignmentPropertiesfor specific expression.Before all
ExpressioninObjectPattern = Expressionwere collected into destructuringAssignmentProperties, but actually we only need to collect some specific expressions:harmonyImportSpecifier,import.meta,import(), and thekey of DefinePlugin options, so this PR add a new hook that identify these expressions and only collectdestructuringAssignmentPropertiesfor them.#18319 (comment) And duo to performance reason that
destructuringAssignmentPropertiesonly collect properties for simple cases like{ a, b: c } = d, after this we can also add collect the nested properties:{ a: { b: {c} } } = din future PRWhat kind of change does this PR introduce?
refactoring, and bugfix for
({ webpack } = await ({ url } = import.meta));Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
No