Skip to content

feat: using support#19626

Merged
alexander-akait merged 7 commits intomainfrom
using
Jun 26, 2025
Merged

feat: using support#19626
alexander-akait merged 7 commits intomainfrom
using

Conversation

@alexander-akait
Copy link
Copy Markdown
Member

@alexander-akait alexander-akait commented Jun 25, 2025

What kind of change does this PR introduce?

fixes #19569

Did you add tests for your changes?

Yes

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

No

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 25, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #19626 will degrade performances by 77.67%

Comparing using (c8210e7) with main (10fb556)

Summary

⚡ 1 improvements
❌ 81 regressions
✅ 51 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 37.4 ms 44.8 ms -16.56%
⚡ benchmark "lodash", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 34.9 ms 27.2 ms +28.22%
❌ benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 11.2 ms 50.1 ms -77.67%
❌ benchmark "react", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 10.8 ms 35.8 ms -69.71%
❌ md4 buffer benchmark (size: 10000) 72.8 µs 114.2 µs -36.25%
❌ md4 buffer benchmark (size: 120) 34.6 µs 76.1 µs -54.49%
❌ md4 buffer benchmark (size: 160) 34.7 µs 76 µs -54.32%
❌ md4 buffer benchmark (size: 16366) 97.1 µs 138.5 µs -29.85%
❌ md4 buffer benchmark (size: 16368) 97.2 µs 138.6 µs -29.9%
❌ md4 buffer benchmark (size: 16370) 97.2 µs 138.6 µs -29.86%
❌ md4 buffer benchmark (size: 2) 34.7 µs 76.2 µs -54.47%
❌ md4 buffer benchmark (size: 20) 32.2 µs 76.3 µs -57.74%
❌ md4 buffer benchmark (size: 200) 34.9 µs 76.3 µs -54.21%
❌ md4 buffer benchmark (size: 2000) 40.5 µs 81.9 µs -50.52%
❌ md4 buffer benchmark (size: 20000) 111.4 µs 152.6 µs -27.04%
❌ md4 buffer benchmark (size: 2002) 40.5 µs 81.9 µs -50.55%
❌ md4 buffer benchmark (size: 40) 32.2 µs 73.5 µs -56.2%
❌ md4 buffer benchmark (size: 400) 35.6 µs 77 µs -53.69%
❌ md4 buffer benchmark (size: 40000) 187.6 µs 229 µs -18.07%
❌ md4 buffer benchmark (size: 65536) 285.9 µs 327.3 µs -12.66%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@alexander-akait
Copy link
Copy Markdown
Member Author

alexander-akait commented Jun 25, 2025 •
edited
Loading

There is a limitation with eval source map - tc39/proposal-explicit-resource-management#136

Let's add {${code}} wrapper for eval to support this

@alexander-akait alexander-akait merged commit 43b0aaf into main Jun 26, 2025
79 of 82 checks passed
@alexander-akait alexander-akait deleted the using branch June 26, 2025 17:10
@ahabhgk ahabhgk mentioned this pull request Aug 15, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

support using / await using (explicit resource management)

1 participant

@alexander-akait