Skip to content

chore: fix todo types#19550

Merged
alexander-akait merged 1 commit intomainfrom
chore-fix-ts-types
May 20, 2025
Merged

chore: fix todo types#19550
alexander-akait merged 1 commit intomainfrom
chore-fix-ts-types

Conversation

@alexander-akait
Copy link
Member

What kind of change does this PR introduce?

chore

Did you add tests for your changes?

No need

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

Nothing

@codspeed-hq
Copy link

codspeed-hq bot commented May 20, 2025

CodSpeed Performance Report

Merging #19550 will improve performances by ×2.5

Comparing chore-fix-ts-types (32343c4) with main (34ec1d8)

Summary

⚡ 80 improvements
✅ 41 untouched benchmarks
⁉️ 12 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ benchmark "devtool-eval", scenario '{"name":"mode-development","mode":"development"}' 221.9 ms N/A N/A
⁉️ benchmark "devtool-eval", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 34.8 ms N/A N/A
⁉️ benchmark "devtool-eval", scenario '{"name":"mode-production","mode":"production"}' 1.1 s N/A N/A
⁉️ benchmark "devtool-eval-source-map", scenario '{"name":"mode-development","mode":"development"}' 250.3 ms N/A N/A
⁉️ benchmark "devtool-eval-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 42.2 ms N/A N/A
⁉️ benchmark "devtool-eval-source-map", scenario '{"name":"mode-production","mode":"production"}' 1.3 s N/A N/A
⁉️ benchmark "devtool-source-map", scenario '{"name":"mode-development","mode":"development"}' 270.5 ms N/A N/A
⁉️ benchmark "devtool-source-map", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 67.1 ms N/A N/A
⁉️ benchmark "devtool-source-map", scenario '{"name":"mode-production","mode":"production"}' 1.8 s N/A N/A
⁉️ benchmark "future-defaults", scenario '{"name":"mode-development","mode":"development"}' 314.4 ms N/A N/A
⁉️ benchmark "future-defaults", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 50.9 ms N/A N/A
⁉️ benchmark "future-defaults", scenario '{"name":"mode-production","mode":"production"}' 2.4 s N/A N/A
benchmark "many-modules-esm", scenario '{"name":"mode-development-rebuild","mode":"development","watch":true}' 52 ms 42.9 ms +21.16%
md4 buffer benchmark (size: 10000) 114.2 µs 73.1 µs +56.22%
md4 buffer benchmark (size: 100000) 447.7 µs 406.6 µs +10.1%
md4 buffer benchmark (size: 120) 76.1 µs 35 µs ×2.2
md4 buffer benchmark (size: 160) 76.1 µs 35 µs ×2.2
md4 buffer benchmark (size: 16366) 138.5 µs 97.4 µs +42.17%
md4 buffer benchmark (size: 16368) 138.5 µs 97.5 µs +42.03%
md4 buffer benchmark (size: 16370) 138.5 µs 97.4 µs +42.15%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@alexander-akait alexander-akait merged commit dc19f82 into main May 20, 2025
42 of 44 checks passed
@alexander-akait alexander-akait deleted the chore-fix-ts-types branch May 20, 2025 10:36
3ru pushed a commit to 3ru/webpack that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant