fix: library module without export statement#19411
Merged
alexander-akait merged 3 commits intowebpack:mainfrom Apr 16, 2025
hai-x:fix-library-disable-provided-export
Merged
fix: library module without export statement#19411alexander-akait merged 3 commits intowebpack:mainfrom hai-x:fix-library-disable-provided-export
alexander-akait merged 3 commits intowebpack:mainfrom
hai-x:fix-library-disable-provided-export
Conversation
…in certain library bundle
| new FlagDependencyExportsPlugin().apply(compiler); | ||
| } | ||
| } | ||
| }).apply(compiler); |
Member
There was a problem hiding this comment.
Looks good, what is about apply it only for require libraries, i.e. where we use getExportsInfo()/getExportInfo()?
Member
Author
There was a problem hiding this comment.
Oh no, I think I forgot to push that code fragment. I’ll push it later tonight, my time.
Member
There was a problem hiding this comment.
Don't worry, thank you for your help
Member
Author
|
After detail check, I found that when
For other call sites of |
3ru
pushed a commit
to 3ru/webpack
that referenced
this pull request
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #18056. Follows #18176.
Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing