add node-module option for node.__file/dirname#14247
Merged
alexander-akait merged 13 commits intomainfrom Jan 10, 2024
Merged
Conversation
evaluate __filename and __dirname for common js modules when output.module to fileURLToPath(import.meta.url) and fileURLToPath(import.meta.url + "/..") respectively
Contributor
|
For maintainers only:
|
sokra
requested changes
Sep 20, 2021
Co-authored-by: Tobias Koppers <tobias.koppers@googlemail.com>
Contributor
4e83305 to
bf01661
Compare
Contributor
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
# Conflicts: # lib/dependencies/CachedConstDependency.js # schemas/WebpackOptions.check.js
sokra
reviewed
Nov 26, 2021
Member
sokra
left a comment
There was a problem hiding this comment.
Found these old review comments... not sure if they are still relevant
| @@ -199,7 +199,8 @@ class JavascriptGenerator extends Generator { | |||
| runtime: generateContext.runtime, | |||
Member
There was a problem hiding this comment.
Unrelated: For performance reasons we should only create templateContext once per module.
# Conflicts: # schemas/WebpackOptions.check.js
# Conflicts: # lib/DependencyTemplate.js # lib/javascript/JavascriptGenerator.js # schemas/WebpackOptions.check.js # types.d.ts
alexander-akait
approved these changes
Dec 25, 2023
Member
alexander-akait
left a comment
There was a problem hiding this comment.
@vankop can you rebase, I think we can merge it and I am fine with it, thank you
Contributor
|
@sokra do you mind if i create PR with a merge commit? I see a few conflicts between this branch and main:
|
Member
|
I'll rebase this PR, no worries. |
Member
|
Yeah, feel free to send again, I am fine with the such improve |
Contributor
|
I've created an issue to document this in webpack/webpack.js.org. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
closes #14072
Did you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
new options node.__filename=node-module / node.__dirname=node-module
generate
__filenameand__dirnamefor common js modules when output.module=true tofileURLToPath(import.meta.url)andfileURLToPath(import.meta.url + "/..")respectively