perf: replace source-map package with @jridgewell/trace-mapping#489
Conversation
The trace-mapping module is faster than source-map in every benchmark https://github.com/jridgewell/trace-mapping#benchmarks
|
@onigoetz I think we need to change it in more places, we don't think it will improve somthing, because we use source maps here only for error reporting |
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
=======================================
Coverage 97.11% 97.11%
=======================================
Files 3 3
Lines 312 312
Branches 114 114
=======================================
Hits 303 303
Misses 9 9
Continue to review full report at Codecov.
|
|
I understand that in this library's case it won't impact performance nor package size greatly However there seems to be a big interest to move away from |
|
@onigoetz I agree, let's migrate, I think we should do the same in css-minimizer-webpack-plugin and maybe somewhere else? 🤔 |
|
Thanks |
|
I personally did a |
|
Feel free to send PRs in other repos 👍 |
This PR contains a:
Motivation / Use-Case
The trace-mapping module is faster than source-map in every benchmark
https://github.com/jridgewell/trace-mapping#benchmarks
It's also being adopted by many packages across the ecosystem (Jest, Babel, Terser at least have included it already)
And it doesn't need to be async like
source-map0.7.*A previous PR to upgrade for
source-map0.7 was refused in the past : #280Breaking Changes
None
Additional Info