Skip to content

chore(deps): update source-map#280

Closed
sibiraj-s wants to merge 1 commit into
webpack:masterfrom
sibiraj-s:update-sourcemap
Closed

chore(deps): update source-map#280
sibiraj-s wants to merge 1 commit into
webpack:masterfrom
sibiraj-s:update-sourcemap

Conversation

@sibiraj-s

Copy link
Copy Markdown

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Sourcemap v0.7 has some performance improvements.
Also removed an unused dependency del

Breaking Changes

None

Additional Info

None

@codecov

codecov Bot commented Jul 29, 2020

Copy link
Copy Markdown

Codecov Report

Merging #280 into master will increase coverage by 0.24%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   92.83%   93.08%   +0.24%     
==========================================
  Files           5        5              
  Lines         405      405              
  Branches      152      153       +1     
==========================================
+ Hits          376      377       +1     
+ Misses         28       27       -1     
  Partials        1        1              
Impacted Files Coverage Δ
src/index.js 94.79% <93.75%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede8439...791db21. Read the comment docs.

@alexander-akait

Copy link
Copy Markdown
Member

Sorry, we can't accept this PR, because webpack and other modules uses old sync version of source-map, also it is used only for errors, so no big perf here

Comment thread src/index.js
@ghost

ghost commented Jul 29, 2020

Copy link
Copy Markdown

because webpack and other modules uses old sync version of source-map

I thought of that, but since there is nothing breaking, I made this PR. I thought may be other packages could update it one at a time.

also it is used only for errors, so no big perf here

I am not completely aware of the internals. We have quite a large app, and minify phase is quite slow, just felt like any improvement is good to have 😅 .

@alexander-akait

Copy link
Copy Markdown
Member

I thought of that, but since there is nothing breaking, I made this PR. I thought may be other packages could update it one at a time.

We want to do it together with all future codebase - future

I am not completely aware of the internals. We have quite a large app, and minify phase is quite slow, just felt like any improvement is good to have sweat_smile .

Updating source map do not improve perf in this case 😄

@sibiraj-s sibiraj-s closed this Jul 29, 2020
@sibiraj-s sibiraj-s deleted the update-sourcemap branch July 29, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants