Add security consideration for computation control-flow attacks#725
Merged
fdwr merged 2 commits intowebmachinelearning:mainfrom Jul 17, 2024
inexorabletash:security-constant-constants
Merged
Add security consideration for computation control-flow attacks#725fdwr merged 2 commits intowebmachinelearning:mainfrom inexorabletash:security-constant-constants
fdwr merged 2 commits intowebmachinelearning:mainfrom
inexorabletash:security-constant-constants
Conversation
Contributor
Author
|
@huningxin & @fdwr - please take a look at merge if it looks good? |
github-actions bot
added a commit
that referenced
this pull request
Jul 17, 2024
SHA: c9e70f6 Reason: push, by fdwr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #443 if constants aren't actually constant then bad things can happen. Add a note to mention that implementations should mitigate this.
Purely editorial change. Fixes #443
Preview | Diff