Link fix: Link to "is empty" not "empty" when an adjective is intended#708
Merged
fdwr merged 2 commits intowebmachinelearning:mainfrom Jun 17, 2024
inexorabletash:fix-is-empty-link
Merged
Link fix: Link to "is empty" not "empty" when an adjective is intended#708fdwr merged 2 commits intowebmachinelearning:mainfrom inexorabletash:fix-is-empty-link
fdwr merged 2 commits intowebmachinelearning:mainfrom
inexorabletash:fix-is-empty-link
Conversation
The Infra term "list/empty" is a verb (to empty); link to "list/is empty" when that's what is intended.
Contributor
Author
|
@fdwr and @huningxin - please take a look? |
huningxin
approved these changes
Jun 13, 2024
Contributor
huningxin
left a comment
There was a problem hiding this comment.
LGTM with a question, thanks!
fdwr
reviewed
Jun 13, 2024
noun to adjective and is not empty text.
Contributor
Author
|
Thanks for updating - LGTM to merge |
fdwr
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Infra term "list/empty" is a verb (to empty); link to "list/is empty" when that's what is intended.
Preview | Diff