Remove entryPoint if not required#334
Conversation
|
FYI @jimblandy @mwyrzykowski this will simplify samples a bit but will require entryPoint name defaulting. |
|
Converting to draft to make the PR harder to accidentally merge. |
|
We can now merge it as Chrome 121 is stable. |
|
ps: Firefox still requires entryPoint as of nightly 124.0a1 (2024-01-25) (64-bit) |
|
So, we agree this is a sweet readability hack, and would like to see it deployed in the examples - but since it will break Firefox, we would like to wait to merge this PR until gfx-rs/wgpu#5145 is closed. |
|
Note that we need both gfx-rs/wgpu#5145 (the |
072d4f2 to
a28b6fd
Compare
|
Firefox Nightly now handles omitted entry point names (I've checked locally). Note that I've just rebased it due to merging conflicts. |
|
As the person who worked on this support in Firefox, I'm excited to see this land. 😁 |
|
I've had to update the PR again. Please review and merge ;) |
There was a problem hiding this comment.
Are the changes to package-lock.json intentional?
There was a problem hiding this comment.
Yes. They are due to me running npm i because of iframe changes.
There was a problem hiding this comment.
But it doesn't look like any of the code changes should affect the packages? Is it that main has a stale package-lock.json? If so, can we do that as a separate PR?
There was a problem hiding this comment.
You're right. I'll revert package-lock.json changes then to not pollute this PR.
|
@kainino0x Can you merge? |
|
I'll merge |
See gpuweb/gpuweb#4387