fix: access ShadowRoot via window.ShadowRoot#9046
Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom Oct 19, 2022
Merged
fix: access ShadowRoot via window.ShadowRoot#9046christian-bromann merged 2 commits intowebdriverio:mainfrom
christian-bromann merged 2 commits intowebdriverio:mainfrom
Conversation
fixes an issue in browsers where ShadowRoot is not available globally (e.g. Edge 18). Error message is "ShadowRoot is not defined". A similar issue was reported here vuejs/test-utils#293 and the fix was referencing ShadowRoot from window instead: https://github.com/vuejs/core/pull/2943/files
|
|
christian-bromann
approved these changes
Oct 19, 2022
Member
christian-bromann
left a comment
There was a problem hiding this comment.
Thanks! 👍
Mind raising the same PR for the v7 branch so I can release is to current stable?
klipstein
added a commit
to klipstein/webdriverio
that referenced
this pull request
Oct 19, 2022
* fix: access ShadowRoot via window.ShadowRoot fixes an issue in browsers where ShadowRoot is not available globally (e.g. Edge 18). Error message is "ShadowRoot is not defined". A similar issue was reported here vuejs/test-utils#293 and the fix was referencing ShadowRoot from window instead: https://github.com/vuejs/core/pull/2943/files * Revert accidentally changed return value
Contributor
Author
|
@christian-bromann thanks for merging. Here is the pull for the v7 branch: #9050 |
christian-bromann
pushed a commit
that referenced
this pull request
Oct 19, 2022
* fix: access ShadowRoot via window.ShadowRoot fixes an issue in browsers where ShadowRoot is not available globally (e.g. Edge 18). Error message is "ShadowRoot is not defined". A similar issue was reported here vuejs/test-utils#293 and the fix was referencing ShadowRoot from window instead: https://github.com/vuejs/core/pull/2943/files * Revert accidentally changed return value
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
fixes an issue in browsers where ShadowRoot is not available globally (e.g. Edge 18). Error message is "ShadowRoot is not defined".
A similar issue was reported here vuejs/test-utils#293 and the fix was referencing ShadowRoot from window instead: https://github.com/vuejs/core/pull/2943/files
Types of changes
Checklist
Further comments
Reviewers: @webdriverio/project-committers