wdio-local-runner: unpipe streams in the end#3882
Merged
christian-bromann merged 2 commits intowebdriverio:masterfrom Apr 25, 2019
mgrybyk:fix-max-listeners-warning
Merged
wdio-local-runner: unpipe streams in the end#3882christian-bromann merged 2 commits intowebdriverio:masterfrom mgrybyk:fix-max-listeners-warning
christian-bromann merged 2 commits intowebdriverio:masterfrom
mgrybyk:fix-max-listeners-warning
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3882 +/- ##
==========================================
+ Coverage 98.57% 98.57% +<.01%
==========================================
Files 153 153
Lines 3432 3434 +2
Branches 749 749
==========================================
+ Hits 3383 3385 +2
Misses 44 44
Partials 5 5
Continue to review full report at Codecov.
|
Member
|
Nice fix! |
abjerstedt
pushed a commit
that referenced
this pull request
Apr 26, 2019
* wdio-local-runner: unpipe streams in the end * wdio-local-runner: transformStream _final test
yamkay
pushed a commit
to MoveInc/webdriverio
that referenced
this pull request
Sep 4, 2019
* wdio-local-runner: unpipe streams in the end * wdio-local-runner: transformStream _final test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously RunnerTransformStream streams were closed.
After recent changes closing stream was causing
Error [ERR_STREAM_WRITE_AFTER_END]: write after endbecauseendwas triggered while streams were in pipe.Added
unpipeand restored stream closing functionality.fixes #3877
Types of changes
Checklist
Further comments
I have some problems with covering this functionality with proper tests.
Just added test to ensure
unpipewas called.Reviewers: @webdriverio/technical-committee