Skip to content

Fix/ getCSSProperty implicit wait on stale element#14937

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
ivanovicu:fix/getCSSProperty-implicit-wait-on-stale-element
Dec 24, 2025
Merged

Fix/ getCSSProperty implicit wait on stale element#14937
christian-bromann merged 2 commits intowebdriverio:mainfrom
ivanovicu:fix/getCSSProperty-implicit-wait-on-stale-element

Conversation

@ivanovicu
Copy link
Contributor

Proposed changes

Replace getCSSProperty('display') with a direct browser.execute(getComputedStyle) call to bypass implicit wait mechanism and handle stale elements without retries.

Types of changes

Fix for #14936

In BiDi protocol when waitForDisplayed({ reverse : true }) is called on an element that has been removed from the DOM,
the implicitWait mechanism attempts to re-locate the element. This causes waitForDisplayed({ reverse : true }) to timeout instead of succeeding when element is removed from DOM.

Root cause:
BiDi protocol: browsingContext.locateNodes returns {nodes: []} for stale elements and the elementId persist on the element object.
Classic WebDriver: The elementId is properly cleared when an element becomes stale, allowing isDisplayed to return early before reaching getCSSProperty.

This PR also reverts changes made to getCSSProperty in #14853, as the root issue should be fixed in isDisplayed rather than modifying the general-purpose getCSSProperty method.

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

… calling getElementCSSValue instead of browser execute command
…to bypass imlicit wait mechanism and handle stale elements immediately
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 15, 2025

Open in StackBlitz

create-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/create-wdio@14937

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14937

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14937

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14937

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14937

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14937

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14937

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14937

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14937

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14937

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14937

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14937

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14937

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14937

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14937

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14937

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14937

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14937

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14937

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14937

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14937

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14937

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14937

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14937

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14937

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14937

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14937

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14937

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14937

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14937

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14937

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14937

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14937

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14937

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14937

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14937

@wdio/xvfb

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/xvfb@14937

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14937

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14937

commit: fe3cf67

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann christian-bromann merged commit bd079c8 into webdriverio:main Dec 24, 2025
59 checks passed
@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Dec 24, 2025
@wdio-bot
Copy link
Contributor

Hey ivanovicu 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expensable $35 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants