Skip to content

Fix: Prevent stale CSS property reads in WebDriver Bidi mode#14853

Merged
christian-bromann merged 3 commits intowebdriverio:mainfrom
ivanovicu:fix/bidi-element-stale-reads
Nov 14, 2025
Merged

Fix: Prevent stale CSS property reads in WebDriver Bidi mode#14853
christian-bromann merged 3 commits intowebdriverio:mainfrom
ivanovicu:fix/bidi-element-stale-reads

Conversation

@ivanovicu
Copy link
Contributor

Proposed changes

This PR proposes obtaining CSS property value using window.getComputedStyle within browser.execute in getCSSProperty function instead of the Classic WebDriver protocol getElementCSSValue command which as of now does not have direct equivalent command in WebDriver BiDi

When using WebDriver Bidi protocol, getCSSProperty() was returning stale values after elements were removed. This caused waitForDisplayed({ reverse: true }) to timeout even when elements became hidden, because the protocol command getElementCSSValue would return outdated CSS values.

In Classic WebDriver mode, element references become invalid immediately when elements are removed, causing fast failures. In BiDi mode, element references remain "valid" longer, leading to stale reads and race conditions.

Fix for #14835

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

…cute to avoid stale element references in WebDriver Bidi mode
…tCSSValue for another browser.execute in isDisplay promise, so we are hiting one less endpoint
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 12, 2025

CLA Signed
The committers listed above are authorized under a signed CLA.

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 14, 2025

Open in StackBlitz

create-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/create-wdio@14853

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14853

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14853

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14853

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14853

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14853

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14853

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14853

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14853

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14853

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14853

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14853

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14853

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14853

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14853

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14853

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14853

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14853

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14853

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14853

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14853

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14853

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14853

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14853

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14853

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14853

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14853

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14853

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14853

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14853

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14853

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14853

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14853

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14853

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14853

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14853

@wdio/xvfb

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/xvfb@14853

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14853

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14853

commit: 7d8d3c1

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Nov 14, 2025
@christian-bromann christian-bromann merged commit 2024554 into webdriverio:main Nov 14, 2025
57 of 59 checks passed
@wdio-bot
Copy link
Contributor

Hey ivanovicu 👋

Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution.

We've sent you an email with further instructions on how to claim your expenses from our development fund.
Please make sure to check your spam folder as well. If you have any questions, feel free to reach out to us at expense@webdriver.io or in the contributing channel on Discord.

We are looking forward to more contributions from you in the future 🙌

Have a nice day,
The WebdriverIO Team 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Expensable $35 💸 PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants