feat:add start appium inspector from the cli#14932
Conversation
create-wdio
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/appium-service
@wdio/browser-runner
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
@wdio/xvfb
webdriver
webdriverio
commit: |
There was a problem hiding this comment.
Pull request overview
This pull request introduces a new CLI tool start-appium-inspector to the wdio-appium-service package, enabling users to quickly start an Appium server and open the Appium Inspector in their browser. The implementation includes comprehensive utility functions for cross-platform process management, extensive test coverage, and clear documentation.
Key Changes
- Added CLI command
start-appium-inspectorwith support for custom ports and Appium server arguments - Implemented robust process lifecycle management with proper cleanup on exit signals (SIGINT/SIGTERM)
- Provided cross-platform browser opening support (macOS, Windows, Linux)
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Added bin entry for the CLI command and exports configuration for the new CLI module |
bin/start-appium-inspector.js |
Entry point script that invokes the CLI with error handling |
src/cli.ts |
Main CLI logic handling argument parsing, Appium startup, browser opening, and cleanup |
src/cli-utils.ts |
Utility functions for port extraction, Appium resolution, process spawning, and browser opening |
tests/cli.test.ts |
Comprehensive test suite for CLI functionality including signal handling and error scenarios |
tests/cli-utils.test.ts |
Extensive tests for utility functions covering edge cases and platform-specific behavior |
README.md |
Documentation for the new CLI command with usage examples and prerequisites |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Nice idea 👍 I would just like to add that the https://inspector.appiumpro.com/ site is hosted by HeadSpin, and maintenance of this site is done by the Appium team members who work there. However, as of right now, nobody from the Appium team works at HeadSpin anymore, which is why the hosted Inspector version is out-of-date, and is unlikely to be updated. In the meantime I could suggest the option of integrating the Inspector's Appium plugin version. You can check the documentation here: https://appium.github.io/appium-inspector/latest/quickstart/installation/#appium-plugin |
|
Hi @eglitise Thanks, I'll do that and will move the PR to in draft. Thanks. I missed that memo 😅 |
- add ut's - optimize code
|
I've changed it, WDYT now? |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
erwinheitzman
left a comment
There was a problem hiding this comment.
I didn't go through everything yet but have left some feedback @wswebcreation 🙂
Np @erwinheitzman , already appreciate that you took the time. I've fixed the last things, maybe we can merge it now and release it |
Proposed changes
This pull request introduces a new CLI tool to the
wdio-appium-servicepackage, making it easier to start the Appium server and open the Appium Inspector in a browser. The implementation includes robust process management, cross-platform support, and comprehensive tests for the new utilities. The documentation is also updated to guide users on using the new CLI.The Appium inspector can be started with the new CLI command,
start-appium-inspector. It willand has support for custom ports and all Appium server arguments.
This is how it looks like
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers