Skip to content

fix(wdio-browserstack-service): resolve BiDi syntax error (#14922)#14923

Merged
christian-bromann merged 2 commits intowebdriverio:mainfrom
mccmrunal:fix/browserstack-bidi-syntax-error
Dec 24, 2025
Merged

fix(wdio-browserstack-service): resolve BiDi syntax error (#14922)#14923
christian-bromann merged 2 commits intowebdriverio:mainfrom
mccmrunal:fix/browserstack-bidi-syntax-error

Conversation

@mccmrunal
Copy link
Contributor

@mccmrunal mccmrunal commented Dec 8, 2025

Proposed changes

Fixes BiDi compatibility issue in @wdio/browserstack-service where using seleniumBidi: 'true' caused SyntaxError: Unexpected token ':' when executing BrowserStack annotations.
FIXES #14922
//: # (Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.)

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

The fix uses a function wrapper approach instead of the magic string
//: # (If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...)

Reviewers: @webdriverio/project-committers

@mccmrunal mccmrunal requested a review from a team as a code owner December 8, 2025 17:09
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 8, 2025

Open in StackBlitz

create-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/create-wdio@14923

eslint-plugin-wdio

npm i https://pkg.pr.new/webdriverio/webdriverio/eslint-plugin-wdio@14923

@wdio/allure-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/allure-reporter@14923

@wdio/appium-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/appium-service@14923

@wdio/browser-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browser-runner@14923

@wdio/browserstack-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/browserstack-service@14923

@wdio/cli

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cli@14923

@wdio/concise-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/concise-reporter@14923

@wdio/config

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/config@14923

@wdio/cucumber-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/cucumber-framework@14923

@wdio/dot-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/dot-reporter@14923

@wdio/firefox-profile-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/firefox-profile-service@14923

@wdio/globals

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/globals@14923

@wdio/jasmine-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/jasmine-framework@14923

@wdio/json-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/json-reporter@14923

@wdio/junit-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/junit-reporter@14923

@wdio/lighthouse-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/lighthouse-service@14923

@wdio/local-runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/local-runner@14923

@wdio/logger

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/logger@14923

@wdio/mocha-framework

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/mocha-framework@14923

@wdio/protocols

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/protocols@14923

@wdio/repl

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/repl@14923

@wdio/reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/reporter@14923

@wdio/runner

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/runner@14923

@wdio/sauce-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sauce-service@14923

@wdio/shared-store-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/shared-store-service@14923

@wdio/smoke-test-cjs-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-cjs-service@14923

@wdio/smoke-test-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-reporter@14923

@wdio/smoke-test-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/smoke-test-service@14923

@wdio/spec-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/spec-reporter@14923

@wdio/static-server-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/static-server-service@14923

@wdio/sumologic-reporter

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/sumologic-reporter@14923

@wdio/testingbot-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/testingbot-service@14923

@wdio/types

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/types@14923

@wdio/utils

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/utils@14923

@wdio/webdriver-mock-service

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/webdriver-mock-service@14923

@wdio/xvfb

npm i https://pkg.pr.new/webdriverio/webdriverio/@wdio/xvfb@14923

webdriver

npm i https://pkg.pr.new/webdriverio/webdriverio/webdriver@14923

webdriverio

npm i https://pkg.pr.new/webdriverio/webdriverio@14923

commit: 0350bf6

@mccmrunal mccmrunal closed this Dec 8, 2025
@mccmrunal mccmrunal reopened this Dec 8, 2025
@mccmrunal mccmrunal closed this Dec 8, 2025
@mccmrunal mccmrunal reopened this Dec 8, 2025
@mccmrunal mccmrunal closed this Dec 9, 2025
@mccmrunal mccmrunal reopened this Dec 9, 2025
Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Dec 24, 2025
@christian-bromann christian-bromann merged commit 4fdb6fe into webdriverio:main Dec 24, 2025
62 checks passed
@yashdsaraf
Copy link

Hey @christian-bromann
Browserstack team is added as the codeowners for wdio-browserstack-service but we were not requested for review here.

This PR led to an issue --> browser.execute is throwing undefined method errors. We'll fix this issue in a separate PR.

Just wanted to make sure we're involved in wdio-browserstack-service reviews so we can catch this early on.

@christian-bromann
Copy link
Member

@yashdsaraf understood. Will have you all review BS related code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: SyntaxError due to invalid JavaScript when seleniumBidi: 'true',

3 participants