fix(webdriver): re-enable undici global dispatcher#14623
Merged
christian-bromann merged 2 commits intomainfrom Jul 8, 2025
Merged
fix(webdriver): re-enable undici global dispatcher#14623christian-bromann merged 2 commits intomainfrom
christian-bromann merged 2 commits intomainfrom
Conversation
eslint-plugin-wdio
@wdio/allure-reporter
@wdio/appium-service
@wdio/browser-runner
@wdio/browserstack-service
@wdio/cli
@wdio/concise-reporter
@wdio/config
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
webdriver
webdriverio
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
After commit b70285e, WebdriverIO started caching dispatchers per session and creating its own proxy agents internally, which means it no longer uses the global dispatcher set via
setGlobalDispatcher().The change was introduced to:
Here's what has changed and why the documentation is now outdated:
What Changed
setGlobalDispatcher()HTTP_PROXY/HTTPS_PROXYenvironment variablesThe Problem
The documentation still recommends using
setGlobalDispatcher()but this no longer works because:HTTP_PROXY/HTTPS_PROXYenvironment variablesThe Solution
Let's ensure we support both to be backwards compatible as well as document the environment only approach.
1. Environment Variables (New, simpler approach)
Users can now simply set standard proxy environment variables:
2. undici's setGlobalDispatcher (Existing approach)
The existing documented approach using
setGlobalDispatchercontinues to work:Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
fixes #14621
Reviewers: @webdriverio/project-committers