-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Description
Pre-check
- I know I can edit the docs but prefer to file this issue
Describe the improvement
Unclear documentation
Description of the improvement / report
I want to enter this issue about the documentation to confirm our understanding is correct and how to best update the documentation.
The documentation page in question is https://webdriver.io/docs/proxy/.
We are using the @wdio/* package suite at 9.11.0 and everything was working from behind a corporate proxy with the above documentation page. However when we upgraded to 9.12.x and beyond, still confirmed broken on ^9.16.2, our proxy setup still isn't working. We are getting timeouts because the proxy seemingly wasn't used.
We dug through the code and found the update here, which was added in the versions that don't seem to work for us. It doesn't seem to use the global dispatcher anymore in favor of making the decision to use a proxy or not internally. And this new proxy value is set from here, which seems to only refer to the env vars HTTP_PROXY or HTTPS_PROXY.
When we set the proxy through HTTP_PROXY or HTTPS_PROXY and re-run the code, everything works again from behind the corporate proxy. We don't even need the setGlobalDispatcher method from undici like it states in the documentation.
So the question is, is using HTTP_PROXY or HTTPS_PROXY through the environment only the intended behavior going forward to use a proxy? Or should WDIO still use the global dispatcher through undici as well to manage connections from behind a proxy?
Code of Conduct
- I agree to follow this project's Code of Conduct