fix(webdriverio): properly handle unresolved element on switchFrame input in non-BIDI scenario#13863
Merged
christian-bromann merged 4 commits intowebdriverio:mainfrom Nov 7, 2024
gavvvr:13856-swithFrame-unresolved-element-promise
Merged
fix(webdriverio): properly handle unresolved element on switchFrame input in non-BIDI scenario#13863christian-bromann merged 4 commits intowebdriverio:mainfrom gavvvr:13856-swithFrame-unresolved-element-promise
switchFrame input in non-BIDI scenario#13863christian-bromann merged 4 commits intowebdriverio:mainfrom
gavvvr:13856-swithFrame-unresolved-element-promise
Conversation
@wdio/browser-runner
@wdio/appium-service
@wdio/browserstack-service
@wdio/allure-reporter
@wdio/cli
@wdio/concise-reporter
@wdio/config
eslint-plugin-wdio
@wdio/cucumber-framework
@wdio/dot-reporter
@wdio/firefox-profile-service
@wdio/globals
@wdio/jasmine-framework
@wdio/json-reporter
@wdio/junit-reporter
@wdio/lighthouse-service
@wdio/local-runner
@wdio/logger
@wdio/mocha-framework
@wdio/protocols
@wdio/repl
@wdio/reporter
@wdio/runner
@wdio/sauce-service
@wdio/shared-store-service
@wdio/smoke-test-cjs-service
@wdio/smoke-test-reporter
@wdio/smoke-test-service
@wdio/spec-reporter
@wdio/static-server-service
@wdio/sumologic-reporter
@wdio/testingbot-service
@wdio/types
@wdio/utils
@wdio/webdriver-mock-service
webdriver
webdriverio
commit: |
erwinheitzman
requested changes
Nov 7, 2024
christian-bromann
approved these changes
Nov 7, 2024
Member
christian-bromann
left a comment
There was a problem hiding this comment.
Great contribution 👍
Contributor
|
Hey gavvvr 👋 Thank you for your contribution to WebdriverIO! Your pull request has been marked as an "Expensable" contribution. We've sent you an email with further instructions on how to claim your expenses from our development fund. We are looking forward to more contributions from you in the future 🙌 Have a nice day, |
christian-bromann
added a commit
that referenced
this pull request
Nov 13, 2024
… input in non-BIDI scenario (#13863) * test(webdriverio): failing `switchFrame` test with unresolved element on input * refactor(webdriverio): extract check into reusable type guard function * fix(webdriverio): properly handle unresolved element in non-BIDI scenario --------- Co-authored-by: Christian Bromann <git@bromann.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #13856
Rearrange the code to handle input the same way in non-BIDI and BIDI scenarios
Types of changes
Checklist
Backport Request
//: # (The current
mainbranch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against thev8branch.)v9and doesn't need to be back-ported#XXXXXFurther comments
Reviewers: @webdriverio/project-committers