Skip to content

fix(@wdio/protocols): remove return value for navigateTo#13335

Merged
christian-bromann merged 1 commit intomainfrom
cb/navigateTo-return
Aug 7, 2024
Merged

fix(@wdio/protocols): remove return value for navigateTo#13335
christian-bromann merged 1 commit intomainfrom
cb/navigateTo-return

Conversation

@christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Aug 7, 2024

Proposed changes

fixes #13332

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: Bug Fix 🐛 PRs that contain bug fixes label Aug 7, 2024
@christian-bromann christian-bromann merged commit 4e349a2 into main Aug 7, 2024
@christian-bromann christian-bromann deleted the cb/navigateTo-return branch August 7, 2024 16:41
johnp added a commit to johnp/webdriverio that referenced this pull request Aug 11, 2024
…-leak

* upstream/main:
  V9 ai support (webdriverio#13340)
  docs(devtools manipulation): (webdriverio#13334)
  breaking(build): migrate to Esbuild for bundling (webdriverio#13338)
  fix(@wdio/protocols): remove return value for navigateTo (webdriverio#13335)
  fix(@wdio/runner): check if getTypes is available when filtering through browser logs
  fix(@wdio/runner): filter for severe errors
  fix(@wdio/runner): retry on Outdated Optimize Dep Vite errors (webdriverio#13330)
  feat(webdriverio): new command to set viewport (webdriverio#13258)
  chore(deps): fix pnpm-lock
  chore(deps): bump vite-plugin-top-level-await from 1.4.1 to 1.4.2 (webdriverio#13282)
  fix(dependabot): fix dependabot ignore setting
  chore(testing): update Vitest to v2
  chore(sponsoring): add Route4Me to Backers.md and Readme.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Bug Fix 🐛 PRs that contain bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: navigateTo should return string or null?

1 participant